Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Shopify/spoom
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.7.1
Choose a base ref
...
head repository: Shopify/spoom
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.7.2
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on May 23, 2025

  1. Avoid deleting comments when the comment is not an annotation 

    We should not add delete edits whenever we see `@` in the comment. This
could cause incorrect ordering in the generated RBI.
This commit fixes it by only adding delete edits when we see an annotation.

Co-authored-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @st0012 @Morriar
    st0012 and Morriar committed May 23, 2025
    Configuration menu
    Copy the full SHA
    ca8cbf9 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #742 from Shopify/fix-annotation-translation-order… 

    …-issue

Avoid deleting comments when the comment is not an annotation
    @st0012
    st0012 authored May 23, 2025
    Configuration menu
    Copy the full SHA
    02b681f View commit details
    Browse the repository at this point in the history

  3. Bump version to v0.17.2

    @st0012
    st0012 committed May 23, 2025
    Configuration menu
    Copy the full SHA
    255fb4a View commit details
    Browse the repository at this point in the history
Loading