Skip to content

Conversation

thepwagner
Copy link
Contributor

@thepwagner thepwagner commented May 29, 2024

Replace the fpm gem for building .deb packages with the nfpm library embedded within goreleaser.

Modify the Makefile to prefer invoking goreleaser for all artifacts. Per the .github/workflows/release.yaml workflow: this Makefile isn't used during the release process, it's inherited cruft.

Moving this logic from the Makefile, which we don't use, to goreleaser, which we do use, means the next tagged release will have a .deb attached with provenance.

This PR also upgrades the dependencies specified in dev.yml: ruby and golang to fresher versions.

Testing Instructions

  • make deb will produce dist/*.deb.
    • Re-running will recreate the build (not reuse): to fix that we'd have to git rev-parse instead of the VERSION file(?), and I don't want to do that.

Related

@thepwagner thepwagner requested a review from burke as a code owner May 29, 2024 13:58
@thepwagner thepwagner self-assigned this May 29, 2024
@thepwagner thepwagner merged commit a42fb30 into main May 29, 2024
@thepwagner thepwagner deleted the nfpm-is-not-fpm branch May 29, 2024 14:12
thepwagner added a commit that referenced this pull request May 29, 2024
In #154 we started uploading `.deb` artifacts.

I forgot we only sign `*.tar.gz`, so the deb's lack provenance. I can not abide.
@thepwagner thepwagner mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants