fix: Construct recent queue track id list as well #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This commit attempts to fix Sherlockouo#117 * This issue may be caused by the "Recent Songs" component not updating the song id at the same time when it is initialized. * Add a simple implementation to statefully update the recent play queue so that the recent queue can be played correctly Signed-off-by: EndCredits <endcredits@crepuscular-aosp.icu>
Closed
Sherlockouo
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to fix #117
This issue may be caused by the "Recent Songs" component not updating the song id at the same time when it is initialized. So add a simple implementation to update the recent play queue statefully so that the recent queue can be played correctly.
Test: Build and boot, tap recent song tab and try to play music, works fine on both NixOS and Windows
CI Build Artifacts: https://github.com/EndCredits/music/actions/runs/7872780723