Skip to content

Conversation

ShenMian
Copy link
Owner

No description provided.

@ShenMian ShenMian requested a review from Copilot May 15, 2025 00:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Bevy dependency to v0.16 along with related dependencies and adjusts the codebase to use the updated APIs. Key changes include replacing direct query accesses with unwrap() after single/single_mut calls, updating event calls from send_default() to write_default(), and changing the board despawn logic.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/systems/render.rs Updates query accesses with unwrap() and replaces send_default() with write_default().
src/systems/level.rs Adjusts query unwrap calls and replaces despawn_recursive() with despawn().
src/systems/input.rs Updates query unwrap calls and event dispatch using write_default().
src/plugins/ui.rs Modifies closure parameter naming and adds unwrap() calls to query methods.
src/plugins/performance_matrix.rs Adds unwrap() calls to query methods and updates plugin initialization.
src/plugins/auto_solve.rs Adds unwrap() calls to query methods for board access and solver updates.
src/plugins/auto_move.rs Updates query unwrap calls to ensure safe access.
Cargo.toml Upgrades dependency versions including bevy, leafwing-input-manager, and bevy_kira_audio.
Comments suppressed due to low confidence (2)

src/systems/level.rs:88

  • The change from despawn_recursive() to despawn() may affect child entity cleanup. Ensure that using despawn() is intentional and that no orphaned child entities remain.
commands.entity(board.single().unwrap()).despawn();

src/systems/render.rs:117

  • Confirm that switching from send_default() to write_default() for event dispatch aligns with the intended event system behavior in the updated Bevy version.
Ordering::Greater => drop(box_enter_goal_events.write_default()),

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (f16d46c) to head (c9cc3d5).

Files with missing lines Patch % Lines
src/systems/render.rs 0.00% 23 Missing ⚠️
src/systems/input.rs 0.00% 9 Missing ⚠️
src/plugins/auto_solve.rs 0.00% 7 Missing ⚠️
src/systems/level.rs 0.00% 5 Missing ⚠️
src/plugins/ui.rs 0.00% 4 Missing ⚠️
src/plugins/auto_move.rs 0.00% 3 Missing ⚠️
src/plugins/performance_matrix.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #18   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         22      22           
  Lines       2351    2356    +5     
=====================================
- Misses      2351    2356    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShenMian ShenMian merged commit 56d8b03 into main May 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants