Update outdated male-specific language #24647
Conversation
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
36eca28 to
ef420a9
Compare
The pronouns “they”/“them” are a better choice, as Serenity does not cater to only men.
ef420a9 to
97b8f12
Compare
| @@ -248,7 +248,7 @@ class UDPSocket final : public Socket { | |||
| // With UDP datagrams, reading a datagram into a buffer that's | |||
| // smaller than the datagram's size will cause the rest of the | |||
| // datagram to be discarded. That's not very nice, so let's bail | |||
| // early, telling the caller that he should allocate a bigger | |||
| // early, telling the caller that they should allocate a bigger | |||
There was a problem hiding this comment.
In this case, the caller isn't a person but a piece of code, I think it would be more appropriate.
There was a problem hiding this comment.
Both would be presumably fine, but the current comment style usually is targeted at the person who wrote the code instead of the code itself (as we make the person aware that they need to consider this possibility while writing code).
|
as a they/them pronouns user yes please this would be super awesome :]]] |
This comment was marked as off-topic.
This comment was marked as off-topic.
wwait how long does it take to find and replace text. have i been doing it wrong this whole time |
NOTE: this PR was closed because of brigading, a new PR is up.Hi @denisdefreyne! We have had the long-standing rule in our project that we do not concern ourselves with controversial topics as to not alienate anyone who'd like to join in the project. This includes topics like geopolitics, ideology, religion, spirituality, drugs, sex, sexuality and gender. You've probably made this PR with good intentions, but as it stands it is considered to be against the aforementioned rule. Objectively the grammar fixes are good, but mentioning "they/them" (while not using "them" in the changes), pronouns, and relating it to males makes this PR a focal point for heated discussions. We are fine with drive-by changes like these as long as they are in context of a good change, and are not referring to anything that breaks one of our rules as outlined on our Discord. Feel free to make a useful technical change that includes grammar fixes like these, but please refrain from putting it in the context of anything that breaks our rules. Thank you for bringing it to our attention however, and the maintainers are going to reevaluate the rules to see if they need to be more specific or otherwise updated. For now, closing this. |
The change I proposed is specifically as to not alienate people who aren’t men… |
The pronouns “they”/“them” are a better choice, as Serenity does not cater to only men.