We can only "catch_violations" on perl v5.35.4 and earlier #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perl v5.35.5 now uses some C99 features. This means that Perl's headers now contain some code with mixed declarations and code. Earlier versions of Perl support long obsolete compilers that are strict in rejecting certain C99 features, particularly mixed declarations and code, hence it still makes sense to audit that our code does not violate this. However, doing this is now only possible on these earlier versions of Perl, hence only add -Werror=declaration-after-statement for 5.035004 and earlier.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl has changed to permitting some C99 features, particularly mixed declarations and code.
For blead, adding
-Werror=declaration-after-statementunconditionally to gcc or clang's flags will break the build. Hence only do it for v5.35.4 and earlier.See Perl/perl5#19172