Can you remove default value for username into SlackWebhookHandler (in construct)
We can into Slack for webhook define default name.
But with monolog, the default name is never use because we send Monolog by default.

Thanks

@jewome62 Good idea. This will allow to use slack internal username settings. I'll check how it works for slack API and get that done. Thanks.

Looking forward to the removal of context fields duplicated in message 👍

@Seldaek Do you think we can do better to support include_stacktraces?
#846 implemented getFormatter, thus if handler has a formatter which supports include_stacktraces and useAttachment === false - it works
In case useAttachment === true, we now have NormalizerFormatter in SlackRecord::stringify which will always include stacktraces and will ignore include_stacktraces. This works for people who want traces in slack, but doesn't work for those who don't.

The only way I see to fully support include_stacktraces is SlackFormatter, which would handle both message and attachment and would have includeStacktraces() setter.

@an1zhegorodov seems like you say a way to do it so I'd say do it if you think there is value in it :)

@Seldaek Just realized it would also require moving most of constructor arguments to the formatter... We might consider that for 2.x

Some visuals on these changes:

• 1.x_short_attachment vs slack_improvements_short_attachment
• 1.x_long_attachment vs slack_improvements_long_attachment

@hkdobrev, @stof, would appreciate a code review

Awaiting this merge to fix issue #902 :)
Thanks @an1zhegorodov

From looking at your screenshots @an1zhegorodov it seems to me one important thing that might be worth adding again is the $record['datetime']. It seems it got lost :)

Otherwise I agree it looks much better, thanks for the work.

@Seldaek Slack has a feature to show date and time below the attachment based on user timezone. That's where datetime is now.

That's what I meant by:

• Use ts attachment key to display datetime considering user timezone

OK sorry :) Looks fine to me then, thanks!

@Seldaek can you release a tag with this one? :)

@an1zhegorodov How is the include_stacktraces switch handled? Let's say I don't use attachments but want to choose whether to include stacktraces.

@mirfilip Whether it is handled or not depends on the formatter. If you use default formatter (which is LineFormatter), then you can use inlcude_stacktraces. However, the attachment will always include stacktraces, because it uses NormalizerFormatter. Here's a comment I wrote during implementation, might also give you and idea how this works.

@an1zhegorodov Stupid me, I was searching for include_stacktraces usage in your PR :( Your comment makes it crystal clear. Again, thx for a good work.