-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Create PEAR System_Daemon handler #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I removed SystemDaemonFormatter in favor of use |
Not sure what the point is here. This forwards logs to a system daemon log it seems. Is there a real use case or is it just for BC support for old apps or something? |
I have used this handler when writing/maintaining daemons with System_Daemon.
I sent this pull request because I think other people may want it as me, but if you judge it only as a mine necessity I will understand. |
The thing is I am trying to avoid new optional dependencies since I'd like to move all optional deps into separate packages for 2.0, so I think it'd be better if you create a new package for this, feel free to call it |
Looks great for me! Thanks. |
I will copy |
Yup it probably should be moved to the src dir to allow re-use. I'll add it to the 2.0 notes thanks. |
@Seldaek one doubt when reading the v2 changes I came to here. Does this means you are planning to move all tests to src folder ? |
@harikt nope, just the TestCase since it could be reused by standalone handler libs. |
Thank you @Seldaek . |
Just like @harikt, just came here because I saw the #197 task list. I don't really get the point of moving the |
System_Daemon is an very stable package to work with daemons in PHP. It already handles logs by itself this pull request aims to integrate System_Daemon and Monolog.
A default formatter was created, since System_Daemon already prefix the date and level to the log message there is no need to duplicate this information, SystemDaemonFormatter is based on LineFormatter but has only channel, message, context and extras.