Fix validatePlatform for MariaDB, check for instance of MariaDBPlatform #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c81f37 to
380b8ce
Compare
Versions of DBAL before 3.3 used or extended the MySQLPlatform when connecting to MariaDB. Because of this the platform check was requiring an instance of MySQLPlatform. This commit fixes MariaDB compatibility with DBAL >=3.3, while remaining compatible with versions prior to that (for now). Fixes ScientaNL#113
380b8ce to
d522183
Compare
Hikariii
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix validatePlatform for MariaDB, check for instance of MariaDBPlatform
Versions of DBAL before 3.3 used or extended the MySQLPlatform when
connecting to MariaDB. Because of this the platform check was
requiring an instance of MySQLPlatform.
This commit fixes MariaDB compatibility with DBAL >=3.3, while remaining
compatible with versions prior to that (for now).
Fixes #113