Skip to content

Redirect ALL un-loadable NetCDF objects to LOAD_PROBLEMS #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jun 3, 2025
Merged

Redirect ALL un-loadable NetCDF objects to LOAD_PROBLEMS #6465

merged 23 commits into from
Jun 3, 2025

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented May 13, 2025 •
edited
Loading

🚀 Pull Request

Description

Closes #6319

Objects

  • Auxiliary coordinates
  • Introduce LoadProblems.Problem.handled flag
  • Introduce LoadProblems.Problem.destination attribute, for maximum context
  • Refactor existing changes to capture objects being added to non-Cube objects too
  • Cube units
  • Cell methods
  • Cube attributes
  • Coordinate systems
  • Cell measures
  • Ancillary variables
  • Mesh content

Consult Iris pull request check list

Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@codecov Codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.32402% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.88%. Comparing base (0e586bf) to head (e6b082c).
⚠️ Report is 133 commits behind head on main.

Files with missing lines Patch % Lines
lib/iris/fileformats/_nc_load_rules/helpers.py 97.22% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6465      +/-   ##
==========================================
+ Coverage   89.83%   89.88%   +0.04%     
==========================================
  Files          90       90              
  Lines       23820    23904      +84     
  Branches     4452     4459       +7     
==========================================
+ Hits        21399    21485      +86     
+ Misses       1670     1667       -3     
- Partials      751      752       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

trexfeathers
trexfeathers commented May 16, 2025
View reviewed changes
trexfeathers
trexfeathers commented May 23, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney reviewed May 28, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney reviewed May 28, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney reviewed May 28, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney reviewed May 28, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney reviewed May 28, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney reviewed May 28, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney reviewed May 28, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @trexfeathers
I've reviewed up to commit 8887c69 (Cell methods) and other than a few minor comments I think this is looking ace so far. 👍

@trexfeathers trexfeathers added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label May 30, 2025
@scitools-ci scitools-ci bot mentioned this pull request May 30, 2025
Closed
scitools-ci[bot]
scitools-ci bot previously requested changes May 30, 2025
View reviewed changes
Copy link
Contributor

@scitools-ci scitools-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see SciTools/.github#146

@trexfeathers trexfeathers marked this pull request as ready for review May 30, 2025 18:30
@trexfeathers trexfeathers added benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts and removed benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts labels Jun 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

⏱️ Performance Benchmark Report: 74a3371

Performance shifts 
| Change   | Before [79272122]    | After [74a3371d]    |   Ratio | Benchmark (Parameter)                                                          |
|----------|----------------------|---------------------|---------|--------------------------------------------------------------------------------|
| -        | 446±80ns             | 367±7ns             |    0.82 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50) |
Full benchmark results 

Benchmarks that have improved:

| Change   | Before [79272122]    | After [74a3371d]    |   Ratio | Benchmark (Parameter)                                                          |
|----------|----------------------|---------------------|---------|--------------------------------------------------------------------------------|
| -        | 446±80ns             | 367±7ns             |    0.82 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50) |

Benchmarks that have stayed the same:

| Change   | Before [79272122]    | After [74a3371d]    |   Ratio | Benchmark (Parameter)                                                                       |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------------------|
|          | 21.8±0.4ms           | 21.6±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 53.7±1ms             | 53.0±0.7ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 35.9±1ms             | 35.6±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 166±2ms              | 167±3ms             |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 23.9±0.3ms           | 23.7±0.5ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 32.0±0.5ms           | 32.0±0.4ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 23.9±0.3ms           | 23.4±0.1ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 32.2±0.5ms           | 31.7±0.4ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 21.7±0.6ms           | 21.3±0.3ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 45.7±0.7ms           | 44.4±0.8ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 126±0.5ms            | 127±0.6ms           |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 128±2ms              | 128±1ms             |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 22.9±0.4ms           | 22.7±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 48.7±0.8ms           | 48.2±0.6ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 24.3±0.6ms           | 24.4±0.4ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                             |
|          | 58.2±0.6ms           | 56.9±0.6ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                              |
|          | 21.7±0.5ms           | 21.3±0.5ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 45.1±0.7ms           | 45.2±0.5ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.09±0.01s           | 1.10±0.03s          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.08±0.01s           | 1.12±0.03s          |    1.04 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 224±3ms              | 216±2ms             |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 355±6ms              | 341±8ms             |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 22.7±0.6ms           | 22.5±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 30.7±0.4ms           | 30.1±0.4ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 23.0±0.4ms           | 22.6±0.3ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 60.0±1ms             | 59.0±1ms            |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 23.5±0.9ms           | 23.9±0.2ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 62.3±0.7ms           | 61.3±0.8ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 24.0±0.7ms           | 23.2±0.5ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 58.5±0.3ms           | 57.7±0.7ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 7.95±0.2ms           | 7.76±0.06ms         |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 22.1±0.4ms           | 21.6±0.2ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 19.7±0.3ms           | 19.6±0.1ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 125±0.6ms            | 124±1ms             |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 8.16±0.3ms           | 8.22±0.03ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 20.0±0.2ms           | 19.9±0.2ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 8.09±0.3ms           | 8.16±0.04ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 20.0±0.3ms           | 19.6±0.1ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 7.64±0.3ms           | 7.71±0.04ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 20.5±0.4ms           | 20.1±0.2ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 24.8±0.6ms           | 24.2±0.3ms          |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 35.3±0.8ms           | 34.1±0.6ms          |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 8.15±0.3ms           | 8.10±0.2ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 21.2±0.6ms           | 20.7±0.3ms          |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 9.65±0.3ms           | 9.34±0.09ms         |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 23.5±0.3ms           | 23.2±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 7.90±0.2ms           | 7.77±0.06ms         |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 20.2±0.6ms           | 20.0±0.1ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 528±4ms              | 530±1ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 536±1ms              | 541±4ms             |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 46.5±0.3ms           | 45.9±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 135±2ms              | 132±1ms             |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 8.04±0.3ms           | 7.88±0.07ms         |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 20.3±0.4ms           | 19.5±0.2ms          |    0.96 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 8.04±0.3ms           | 8.12±0.1ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 22.9±0.4ms           | 22.5±0.4ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 8.46±0.2ms           | 8.26±0.1ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 22.2±0.4ms           | 21.8±0.5ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 8.44±0.1ms           | 8.25±0.06ms         |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 22.1±0.3ms           | 21.3±0.3ms          |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 23.3±0.5ms           | 22.9±0.4ms          |    0.98 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 83.0±0.8ms           | 82.9±0.8ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 23.1±0.5ms           | 23.1±0.2ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 96.1±0.9ms           | 95.6±1ms            |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 22.0±0.4ms           | 22.0±0.4ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 56.1±1ms             | 54.8±0.5ms          |    0.98 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 8.16±0.3ms           | 8.22±0.03ms         |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 27.0±0.3ms           | 27.1±0.5ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 8.32±0.2ms           | 8.05±0.08ms         |    0.97 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 28.8±0.4ms           | 28.2±0.7ms          |    0.98 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 8.17±0.3ms           | 7.76±0.09ms         |    0.95 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 22.8±0.3ms           | 22.7±0.4ms          |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 219±3ms              | 217±4ms             |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 273±6ms              | 275±3ms             |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.16±0.04ms          | 1.14±0.01ms         |    0.98 | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 403±20μs             | 395±6μs             |    0.98 | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 991±40μs             | 985±8μs             |    0.99 | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 575±10μs             | 587±10μs            |    1.02 | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 87.6±2ms             | 85.8±2ms            |    0.98 | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 25.7±0.3ms           | 25.7±0.4ms          |    1    | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 99.5±2ms             | 98.0±0.9ms          |    0.99 | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 18.0±1μs             | 17.3±0.2μs          |    0.96 | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 86.8±2ms             | 85.5±0.6ms          |    0.99 | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 26.9±0.3ms           | 26.5±0.5ms          |    0.98 | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 102±2ms              | 101±1ms             |    0.99 | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 17.7±0.9μs           | 17.7±0.3μs          |    1    | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 168±2ms              | 170±2ms             |    1.01 | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 67.5±0.8ms           | 67.8±0.9ms          |    1    | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 200±2ms              | 196±3ms             |    0.98 | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 54.6±0.6μs           | 53.7±0.5μs          |    0.98 | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 251±8ms              | 241±2ms             |    0.96 | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 137±2ms              | 138±2ms             |    1.01 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 273±2ms              | 269±3ms             |    0.98 | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 56.7±0.5μs           | 55.7±0.5μs          |    0.98 | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 826±20μs             | 809±10μs            |    0.98 | import_iris.Iris.time__concatenate                                                          |
|          | 188±3μs              | 185±1μs             |    0.99 | import_iris.Iris.time__constraints                                                          |
|          | 114±0.8μs            | 112±4μs             |    0.99 | import_iris.Iris.time__data_manager                                                         |
|          | 91.0±0.6μs           | 92.0±0.7μs          |    1.01 | import_iris.Iris.time__deprecation                                                          |
|          | 164±3μs              | 160±1μs             |    0.98 | import_iris.Iris.time__lazy_data                                                            |
|          | 926±5μs              | 919±5μs             |    0.99 | import_iris.Iris.time__merge                                                                |
|          | 75.6±0.7μs           | 74.3±0.2μs          |    0.98 | import_iris.Iris.time__representation                                                       |
|          | 621±6μs              | 621±8μs             |    1    | import_iris.Iris.time_analysis                                                              |
|          | 138±0.9μs            | 140±1μs             |    1.02 | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 105±0.9μs            | 107±1μs             |    1.02 | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 245±6μs              | 246±2μs             |    1    | import_iris.Iris.time_analysis__interpolation                                               |
|          | 191±5μs              | 190±2μs             |    0.99 | import_iris.Iris.time_analysis__regrid                                                      |
|          | 110±0.9μs            | 109±0.9μs           |    0.99 | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 137±2μs              | 136±1μs             |    0.99 | import_iris.Iris.time_analysis_calculus                                                     |
|          | 325±1μs              | 324±2μs             |    1    | import_iris.Iris.time_analysis_cartography                                                  |
|          | 91.5±0.7μs           | 90.9±2μs            |    0.99 | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 212±2μs              | 212±1μs             |    1    | import_iris.Iris.time_analysis_maths                                                        |
|          | 95.0±1μs             | 94.0±0.5μs          |    0.99 | import_iris.Iris.time_analysis_stats                                                        |
|          | 170±0.9μs            | 169±0.9μs           |    0.99 | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 317±3μs              | 317±6μs             |    1    | import_iris.Iris.time_aux_factory                                                           |
|          | 80.5±0.3μs           | 80.4±0.8μs          |    1    | import_iris.Iris.time_common                                                                |
|          | 157±1μs              | 158±0.9μs           |    1    | import_iris.Iris.time_common_lenient                                                        |
|          | 1.37±0.01ms          | 1.37±0.01ms         |    1    | import_iris.Iris.time_common_metadata                                                       |
|          | 166±0.8μs            | 169±5μs             |    1.02 | import_iris.Iris.time_common_mixin                                                          |
|          | 1.17±0.01ms          | 1.17±0ms            |    1    | import_iris.Iris.time_common_resolve                                                        |
|          | 201±2μs              | 197±4μs             |    0.98 | import_iris.Iris.time_config                                                                |
|          | 128±1μs              | 128±2μs             |    1    | import_iris.Iris.time_coord_categorisation                                                  |
|          | 384±2μs              | 391±7μs             |    1.02 | import_iris.Iris.time_coord_systems                                                         |
|          | 765±3μs              | 767±4μs             |    1    | import_iris.Iris.time_coords                                                                |
|          | 646±4μs              | 652±4μs             |    1.01 | import_iris.Iris.time_cube                                                                  |
|          | 243±1μs              | 243±2μs             |    1    | import_iris.Iris.time_exceptions                                                            |
|          | 74.8±0.9μs           | 75.0±0.3μs          |    1    | import_iris.Iris.time_experimental                                                          |
|          | 184±2μs              | 181±0.9μs           |    0.98 | import_iris.Iris.time_fileformats                                                           |
|          | 256±5μs              | 257±2μs             |    1    | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.63±0.02ms          | 2.64±0.01ms         |    1    | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 75.4±0.4μs           | 76.5±0.2μs          |    1.01 | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 112±1μs              | 113±1μs             |    1.01 | import_iris.Iris.time_fileformats_abf                                                       |
|          | 425±3μs              | 433±6μs             |    1.02 | import_iris.Iris.time_fileformats_cf                                                        |
|          | 4.70±0.06ms          | 4.69±0.04ms         |    1    | import_iris.Iris.time_fileformats_dot                                                       |
|          | 70.8±1μs             | 72.2±1μs            |    1.02 | import_iris.Iris.time_fileformats_name                                                      |
|          | 248±4μs              | 247±0.7μs           |    1    | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 113±0.9μs            | 113±0.6μs           |    1    | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 119±0.9μs            | 120±2μs             |    1.01 | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 213±5μs              | 213±4μs             |    1    | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 804±4μs              | 809±9μs             |    1.01 | import_iris.Iris.time_fileformats_pp                                                        |
|          | 178±5μs              | 178±0.9μs           |    1    | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 134±2μs              | 133±2μs             |    0.99 | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 550±2μs              | 542±3μs             |    0.99 | import_iris.Iris.time_fileformats_rules                                                     |
|          | 223±4μs              | 219±2μs             |    0.98 | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 80.2±1μs             | 80.9±0.6μs          |    1.01 | import_iris.Iris.time_fileformats_um                                                        |
|          | 160±1μs              | 155±0.8μs           |    0.97 | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 138±5μs              | 136±2μs             |    0.99 | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 72.2±0.8μs           | 71.9±0.4μs          |    1    | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 77.3±1μs             | 78.8±0.7μs          |    1.02 | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 971±7μs              | 973±10μs            |    1    | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 135±1μs              | 136±2μs             |    1    | import_iris.Iris.time_io                                                                    |
|          | 177±2μs              | 177±3μs             |    1    | import_iris.Iris.time_io_format_picker                                                      |
|          | 209±0.6μs            | 207±2μs             |    0.99 | import_iris.Iris.time_iris                                                                  |
|          | 126±1μs              | 125±1μs             |    0.99 | import_iris.Iris.time_iterate                                                               |
|          | 8.30±0.04ms          | 8.19±0.03ms         |    0.99 | import_iris.Iris.time_palette                                                               |
|          | 1.79±0.03ms          | 1.77±0ms            |    0.99 | import_iris.Iris.time_plot                                                                  |
|          | 220±2μs              | 217±1μs             |    0.98 | import_iris.Iris.time_quickplot                                                             |
|          | 2.17±0.04ms          | 2.19±0.03ms         |    1.01 | import_iris.Iris.time_std_names                                                             |
|          | 1.87±0.01ms          | 1.87±0.02ms         |    1    | import_iris.Iris.time_symbols                                                               |
|          | 99.0±1ms             | 99.3±1ms            |    1    | import_iris.Iris.time_tests                                                                 |
|          | 252±2μs              | 254±3μs             |    1.01 | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 5.05±0.03ms          | 5.10±0.03ms         |    1.01 | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 117±0.1μs            | 117±2μs             |    1    | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.76±0.03ms          | 2.74±0.02ms         |    0.99 | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 1.32±0.01ms          | 1.31±0ms            |    0.99 | import_iris.Iris.time_third_party_numpy                                                     |
|          | 167±3μs              | 167±1μs             |    1    | import_iris.Iris.time_third_party_scipy                                                     |
|          | 100±0.9μs            | 98.9±2μs            |    0.98 | import_iris.Iris.time_time                                                                  |
|          | 350±3μs              | 351±3μs             |    1    | import_iris.Iris.time_util                                                                  |
|          | 73.8±1μs             | 73.7±0.9μs          |    1    | iterate.IZip.time_izip                                                                      |
|          | 9.53±0.1ms           | 9.72±0.04ms         |    1.02 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 15.4±0.1ms           | 16.0±0.3ms          |    1.04 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 9.70±0.1ms           | 9.69±0.04ms         |    1    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 9.57±0.2ms           | 9.69±0.1ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 13.1±0.1ms           | 13.2±0.2ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 9.71±0.2ms           | 9.74±0.2ms          |    1    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.43±0.02s           | 1.45±0.01s          |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 12.3±0.2ms           | 12.1±0.1ms          |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.47±0.04s           | 1.47±0.01s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.46±0.04s           | 1.45±0.02s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 12.1±0.2ms           | 12.1±0.1ms          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.49±0.04s           | 1.48±0s             |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 5.17±0.06ms          | 5.19±0.03ms         |    1    | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 11.8±0.03ms          | 11.8±0.06ms         |    1    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 5.23±0.08ms          | 5.12±0.03ms         |    0.98 | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 5.08±0.09ms          | 5.15±0.05ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 11.7±0.1ms           | 11.8±0.08ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 5.07±0.2ms           | 5.11±0.01ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 23.3±1ms             | 22.9±0.8ms          |    0.98 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 27.5±0.6ms           | 27.2±0.2ms          |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 12.2±1ms             | 12.1±1ms            |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 28.6±0.6ms           | 28.3±1ms            |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 70.6±3ms             | 70.9±3ms            |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 28.1±1ms             | 28.2±1ms            |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 606±7ms              | 600±2ms             |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 3.42±0.1ms           | 3.35±0.07ms         |    0.98 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 606±7ms              | 603±2ms             |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 622±4ms              | 612±3ms             |    0.98 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 3.52±0.2ms           | 3.38±0.09ms         |    0.96 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 615±8ms              | 611±2ms             |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 2.12±0.05ms          | 2.09±0.09ms         |    0.99 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 3.49±0.2ms           | 3.36±0.1ms          |    0.96 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 2.15±0.09ms          | 2.04±0.05ms         |    0.95 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 2.05±0.05ms          | 2.12±0.08ms         |    1.04 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 3.54±0.1ms           | 3.46±0.07ms         |    0.98 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 2.16±0.09ms          | 2.07±0.07ms         |    0.96 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 343±0.8ms            | 344±4ms             |    1    | load.ManyCubes.time_many_cube_load                                                          |
|          | 88.1±0.2ms           | 87.8±0.4ms          |    1    | load.ManyVars.time_many_var_load                                                            |
|          | 9.72±0.2ms           | 9.82±0.09ms         |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 9.81±0.2ms           | 9.80±0.02ms         |    1    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.45±0.04s           | 1.46±0.01s          |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.48±0.04s           | 1.48±0.01s          |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 5.26±0.1ms           | 5.15±0.03ms         |    0.98 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 5.18±0.1ms           | 5.17±0.02ms         |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 8.80±0.05ms          | 8.69±0.06ms         |    0.99 | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 5.50±0.03ms          | 5.59±0.02ms         |    1.02 | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.45±0.02s           | 1.44±0.02s          |    1    | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 420±6ms              | 423±5ms             |    1.01 | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.22±0.04ms          | 4.25±0.02ms         |    1.01 | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.15±0.03ms          | 4.18±0.03ms         |    1.01 | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 157±2ms              | 157±2ms             |    1    | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 14.8±0.2ms           | 15.0±0.1ms          |    1.01 | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 160±2ms              | 159±1ms             |    1    | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 31.5±0.7ms           | 31.8±0.3ms          |    1.01 | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 14.6±0.1ms           | 14.7±0.1ms          |    1    | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 32.1±0.6ms           | 31.9±0.6ms          |    0.99 | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 15.0±0.3ms           | 15.5±0.4ms          |    1.04 | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 45.2±1ms             | 45.6±0.7ms          |    1.01 | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 8.79±0.2ms           | 8.81±0.09ms         |    1    | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 16.1±0.4ms           | 15.8±0.5ms          |    0.98 | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 14.9±0.3ms           | 15.0±0.5ms          |    1.01 | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 15.1±0.2ms           | 14.8±0.6ms          |    0.98 | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 8.78±0.2ms           | 8.88±0.2ms          |    1.01 | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 11.2±0.2ms           | 11.3±0.2ms          |    1.01 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 16.0±0.2ms           | 16.2±0.2ms          |    1.01 | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 55.9±0.6ms           | 55.6±0.9ms          |    0.99 | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 16.2±0.3ms           | 15.9±0.3ms          |    0.98 | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 17.3±0.5ms           | 17.0±0.5ms          |    0.99 | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 3.34±0.1ms           | 3.22±0.06ms         |    0.97 | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 4.50±0.9ms           | 4.77±0.9ms          |    1.06 | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 35.4±0.7ms           | 35.7±1ms            |    1.01 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 783±8ms              | 796±10ms            |    1.02 | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 1.56±0.03s           | 1.55±0.03s          |    0.99 | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 431±6ms              | 429±6ms             |    0.99 | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 2.42±0G              | 2.42±0G             |    1    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 120±6M               | 115±5M              |    0.96 | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 36.4±3ms             | 35.0±3ms            |    0.96 | merge_concat.Merge.time_merge                                                               |
|          | 126±0.02M            | 126±0.02M           |    1    | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 197±2ms              | 197±1ms             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 772±0.5k             | 771±0.5k            |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.2±0M              | 60.2±0M             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 16.6±0.3ms           | 16.4±0.1ms          |    0.99 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 20.0±0.2ms           | 19.6±0.4ms          |    0.98 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 1.27±0.04M           | 1.27±0.04M          |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 25±0.04M             | 25±0.04M            |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 116±2ms              | 118±2ms             |    1.02 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 581±6ms              | 581±6ms             |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.47±0.08M           | 1.49±0.02M          |    1.02 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.5±0.01M           | 96.5±0.02M          |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 76.4±0.5ms           | 76.0±0.6ms          |    0.99 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 535±5ms              | 537±3ms             |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.46±0.04M           | 1.43±0.02M          |    0.98 | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.4±0.04M           | 96.5±0.02M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997   | 2.1752849999999997  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998   | 216.01528499999998  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.81±0.1ms           | 6.73±0.09ms         |    0.99 | plot.AuxSort.time_aux_sort                                                                  |
|          | 78.6±5ms             | 80.5±2ms            |    1.02 | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M               | 136±3M              |    1    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 107±4ms              | 104±6ms             |    0.98 | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 58.3±0.6ms           | 58.5±0.6ms          |    1    | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 107±0.06M            | 107±0.06M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.04M            | 147±0.04M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.70±0.02ms          | 4.75±0.05ms         |    1.01 | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 80.4±0.7ms           | 79.9±0.8ms          |    0.99 | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 41.9±0.6ms           | 41.6±0.6ms          |    0.99 | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 478±5ms              | 474±3ms             |    0.99 | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 87.1±1ns             | 87.0±1ns            |    1    | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 62.8±0.4ms           | 63.6±1ms            |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 87.1±0.7ns           | 87.3±1ns            |    1    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 422±6ms              | 418±3ms             |    0.99 | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 31.5±0.4k            | 31.7±0.5k           |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.9±0.09M            | 1.67±0.1M           |    0.88 | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 31.5±0.5k            | 31.5±0.4k           |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 225±20M              | 191±20M             |    0.85 | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 39.6±0.4ms           | 39.1±0.2ms          |    0.99 | stats.PearsonR.time_lazy                                                                    |
|          | 9.19±0.1ms           | 9.26±0.1ms          |    1.01 | stats.PearsonR.time_real                                                                    |
|          | 29.4±0.2M            | 29.5±0.2M           |    1    | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.4±0.01M           | 18.4±0.01M          |    1    | stats.PearsonR.tracemalloc_real                                                             |
|          | 24.4±0.4ms           | 24.9±0.5ms          |    1.02 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 61.0±0.9ms           | 61.5±0.5ms          |    1.01 | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 17.6±0.02M           | 17.6±0.02M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 7.75±0.02M           | 7.75±0.02M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Generated by GHA run 15390732305

@trexfeathers trexfeathers mentioned this pull request Jun 2, 2025
Merged
ukmo-ccbunney
ukmo-ccbunney reviewed Jun 3, 2025
View reviewed changes
ukmo-ccbunney
ukmo-ccbunney approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work - especially as its not as simple to implement in some places as we might have first thought. Nice one @trexfeathers! 💯
LGTM!

@ukmo-ccbunney ukmo-ccbunney dismissed scitools-ci[bot]’s stale review June 3, 2025 15:47

Issue SciTools/.github#146 raised by scitools-ci[bot] for templated file change.

@ukmo-ccbunney ukmo-ccbunney merged commit 7ce8d43 into SciTools:main Jun 3, 2025
21 checks passed
@trexfeathers trexfeathers mentioned this pull request Jun 12, 2025
Closed
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Jul 2, 2025
@pp-mo pp-mo mentioned this pull request Jul 11, 2025
Merged
@trexfeathers trexfeathers deleted the all-tolerance branch August 22, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukmo-ccbunney ukmo-ccbunney ukmo-ccbunney approved these changes

@scitools-ci scitools-ci[bot] scitools-ci[bot] left review comments

Assignees
No one assigned
Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts Feature: NetCDF + CF-conventions Release: Minor Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture ALL un-loadable NetCDF objects
2 participants
@trexfeathers @ukmo-ccbunney