Make MeshCoords immutable and sync updates with the attached mesh #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
reviewed
Jun 23, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6405 +/- ##
==========================================
+ Coverage 89.88% 89.89% +0.01%
==========================================
Files 90 90
Lines 23945 24123 +178
Branches 4467 4489 +22
==========================================
+ Hits 21522 21685 +163
- Misses 1670 1679 +9
- Partials 753 759 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ESadek-MO
commented
Jul 1, 2025
stephenworsley
requested changes
Jul 2, 2025
stephenworsley
requested changes
Jul 2, 2025
stephenworsley
requested changes
Jul 2, 2025
stephenworsley
requested changes
Jul 2, 2025
stephenworsley
previously requested changes
Jul 3, 2025
|
Thanks @ESadek-MO @stephenworsley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #4757, continues #6125.
This pull request aims to make MeshCoords immutable, and when it's corresponding Mesh updates, for the MeshCoord to refresh its Points, Bounds, and Metadata from the Mesh.
Notes to self
nodehad no bounds, has been solved.boundsis set to an error message aboutbounds_dm, but it seems like that's a red herring, and is solved within__init__.