-
Notifications
You must be signed in to change notification settings - Fork 387
ENH: Azimuthal rotation for Orthographic projection #2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm guessing you'll need to put a version gate around this parameter so that we only use it if the underlying PROJ library >= 9.5. Here is an example in our tests cartopy/lib/cartopy/tests/test_crs.py Line 95 in 0c51cbb
What happens if we pass this parameter to the projection in earlier versions, do we get a warning or do we need to issue a warning on our side that the parameter has no effect and will be ignored? |
ping @kenhira , are you able to add the version gate on this parameter? |
Apologies for my slow response. I have implemented the version gate (
I tested on my end with |
Thanks @kenhira! That all looks good to me. |
Rationale
This update adds
azimuth
argument toccrs.Orthographic()
, with a corresponding test. It will enable users to rotate the projection around the central point. It uses new Proj parameteralpha
, which was added toOrthographic
in Proj version 9.5.0.https://proj.org/en/stable/operations/projections/ortho.html
An equivalent
azimuth
argument has already been implemented toccrs.ObliqueMercator()
.Implications
Users will become able to rotate the map as they prefer. For example, one can orient a satellite image along the solar direction to emphasize which direction the sun glint and shadow appear.
This update is a minimal update, adding just one argument to the function.