Skip to content

Conversation

greglucas
Copy link
Contributor

Rationale

The various Natural Earth datasets can have different file members within them. Rather than explicitly iterating through the list of expected files, lets just extract all of them. This adds a datasetname.README.txt and datasetname.VERSION.txt which could be helpful for debugging purposes too and the sizes are very small for the extra files.

closes #2319

Implications

@greglucas
Copy link
Contributor Author

This is failing because we allow the renaming of file contents when extracting an archive. The content within the zipfile is: ne_110m_rivers_lake_centerlines.shp, but the download template wants to rename that to: {category}_{resolution}_{name}.shp. I'm not sure I fully agree with the ability to rename a file coming from an archive, versus making the reader handle different formatted filenames, but I do sort of see why you may want to do that to try and organize things your own way too.

@bjlittle
Copy link
Member

@greglucas Just a thought ... is there a compromise here to extract everything in the zipfile as you've implemented, but also as a convenience create links to the original assets following the existing cartopy naming convention?

Or will that just muddy the waters?

@greglucas
Copy link
Contributor Author

Just a thought ... is there a compromise here to extract everything in the zipfile as you've implemented, but also as a convenience create links to the original assets following the existing cartopy naming convention?

Or will that just muddy the waters?

@bjlittle, that is an interesting thought. I'm not opposed to it, but I do wonder if we need the renaming or if we can just get rid of that capability and simplify our lives a bit...

@greglucas
Copy link
Contributor Author

superseded by #2534 so closing this version.

@greglucas greglucas closed this May 28, 2025
@greglucas greglucas deleted the ne-zipfile branch May 28, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Error using Natural Earth POV files
2 participants