Fix failing gouraud shading mask creation in pccolormesh #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Docs generation seems to fail given an unrelated issue to this PR. Ready for review. THX. |
greglucas
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Using pccolormesh with gouraud shading fails on wrap around mask creation, since numpy array mask is created with negative dimension.
Details: Fails here https://github.com/SciTools/cartopy/blob/main/lib/cartopy/mpl/geoaxes.py#L1896 because
data_shape equals (Nx, Ny, -1) or (Ny - 1, Nx - 1, -1).
Implications
As far as I can see there are no implications of the proposed change.