-
Notifications
You must be signed in to change notification settings - Fork 387
ENH: Use shapefile crs attribute when possible #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems really odd that those would be different. |
74f1a77
to
211b77d
Compare
I just pushed an update that puts the same logic into each of the readers so there isn't any difference between FionaReader and BasicReader in how you get a WKT and we rely on pyproj's version to decode the |
Not sure what's up with CI. |
I'm going to move this back to draft for now so it doesn't get merged. The docs failures are real and I assume due to an interaction of this new CRS for NaturalEarth and the handling updated in #2455 The other thing I noticed looking through the logs is that we have a lot of UserWarnings now:
which means that UserWarning gets printed a lot because it is associated with every natural earth feature now. |
When reading in the shapefile, use the .prj file information if it is present to set a crs attribute on the reader which can be used down the line by features to get the correct Projection.
Adds a default global extent to geographic CRSs unless an area of use is provided and that takes precedence if so. Change shapefile CRS() to Projection() so that Cartopy can project the geometries and extents once added to the maps.
211b77d
to
2f6bf59
Compare
OK, I got back to looking at this again and will put it up for review. I added a new commit that fixes the previous issues I was running into.
|
When reading in the shapefile, use the .prj file information if it is present to set a crs attribute on the reader which can be used down the line by features to get the correct Projection.
Somewhat interesting that loading the wkt from the file produces a different CRS than the one going through Fiona's CRS first... I'm not sure if that is expected or not, so opening this PR as a draft for now.
closes ##906
closes #2289