Address test failures and remove some xfails #2114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
greglucas
commented
Dec 13, 2022
- Add an xfail when parsing bad XML for the two recent tests that are failing now.
- owslib 0.20 was released over two years ago now and fixed some of the reasons for test failures so we can remove some xfails that should always pass.
dopplershift
approved these changes
Dec 13, 2022
stickler-ci
reviewed
Dec 13, 2022
|
It seems our circleCI build is fundamentally broken? |
0e6e2bb to
eb1b17c
Compare
I'm not sure what happened there... I think it is back now. |
This release fixed some broken tests that we were xfailing, so we can remove the xfails as well.
eb1b17c to
55aa87a
Compare
|
There is no winning with our test suite :) Appveyor is now failing on an unrelated test. |
| @@ -191,7 +191,6 @@ def world_file_extent(*args, **kwargs): | |||
| return extent, pix_size | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail(reason='MapQuest is unavailable') | |||
There was a problem hiding this comment.
I think this is the test failing on AppVeyor?
There was a problem hiding this comment.
Ahh, yes, thanks for catching that! I don't think this is the right xfail. I think it was failing on all Windows installs due to the path separator in the path. Just pushed a new commit to see if that does it.
QuLogic
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.