TST: Skip lakes test for pyshp 2.2 #2022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyshp 2.2 reverses the order of the lakes shapefile, which is not what we want for this test. They are discussing reverting that change, so just skip this version for now.
|
I was thinking we'd just reverse the |
|
I was just trying to get the tests passing again, and because this seems to be a potentially one-off situation I decided to skip it for this version instead of altering any tests. I'd be fine with a different approach too if you want to PR something. |
|
I merged #2028, so we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyshp 2.2 reverses the order of the lakes shapefile, which is not what
we want for this test. They are discussing reverting that change, so
just skip this version for now.
xref: #2012