-
Notifications
You must be signed in to change notification settings - Fork 388
Matplotlib contour labelling #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jan 7, 2019
pelson
commented
Jan 7, 2019
59462cb
to
db35061
Compare
stickler-ci
reviewed
Jan 10, 2019
db35061
to
10e4842
Compare
10e4842
to
fcea37e
Compare
40e271f
to
37c0228
Compare
37c0228
to
98cdfff
Compare
Closed
dopplershift
approved these changes
Jan 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resetting __class__
is a bit gnarly, but I don't see a better way without a bunch more boilerplate code.
@dopplershift - merge at will! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
After debugging the issue with matplotlib's contour labelling (seen in #13), it is clear that it was designed before there was a strong transform and path capability. For example, it assumes that there is only one polygon per Path (it completely ignores codes), and it also assumes that paths can be transformed by simply transforming the vertices. Because of this I solved the problem by pre-transforming the paths to the axes coordinate system, and splitting any multi-poly Paths. With this in place, the existing contour labelling functionality works reasonably well (there is room for improvement with the label placement, but that would be a matplotlib enhancement).
Implications
matplotlib.path
module. I haven't done this yet, and don't think I will have the time to do it justiceGeoAxes.contour[f]
to acartopy.mpl.contour.GeoContourSet
(via ugly polymorphism)