-
Notifications
You must be signed in to change notification settings - Fork 388
Add Matplotlib geo projections #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests passing (haven't looked into the reason they aren't).
Any thoughts on Hammer parameters? It seems like 4.9.3 might be buggy with one of these. |
As in The test is failing with a lot of warnings, but they may be not an issue? The image that now has all of the projections is (copied from Travis): |
Interest in coming back to these projections? |
Rebased, but I did not add the other parameters. I'm also not sure if the threshold needs setting nowadays. |
Oops, created the test images with the oldest supported Matplotlib instead of the latest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had one minor comment, which should probably be a follow-up PR. Looks good to me otherwise.
.. note:: | ||
This projection does not handle elliptical globes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this note appears anywhere in the docs? It seems like all of the init docstrings are left out currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe it was with the change in doc themes? I don't remember what the older one looked like now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can open up another issue if we want to update the docs later.
Sorry, I actually meant to merge this in before the release and just forgot. |
Rationale
In Matplotlib, there are 4 builtin geo projections: Aitoff, Hammer, Mollweide, and Lambert. They are not quite as flexible as Cartopy, but work for maps at least. We have the latter two, but not the former.
Implications
This adds Aitoff and Hammer. In proj, Hammer support two more parameters:
+W
and+M
. I do not know what these stand for, so I have not added them, but would like to if anyone has any understanding of what they mean.