Skip to content

Added binary and hex base to script number #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2025
Merged

Added binary and hex base to script number #1605

merged 2 commits into from
Mar 17, 2025

Conversation

KenthJohan
Copy link
Contributor

@KenthJohan KenthJohan commented Mar 15, 2025 •
edited
Loading

Supports binary and hex number in script.
Decimal: 123
Hexadecimal 0xABC (Added support)
Binary 0b01010101 (Added support)

This PR have some duplicate code.

Another approach would be to introduce more token enums like this:

  • EcsTokNumber base 10
  • EcsTokNumberHex base 16
  • EcsTokNumberBin base 2

@SanderMertens
Copy link
Owner

LGTM, thanks for the PR!

@SanderMertens SanderMertens merged commit e6be41f into SanderMertens:master Mar 17, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenthJohan @SanderMertens