-
-
Notifications
You must be signed in to change notification settings - Fork 542
Completed: Fix #1538 #1579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed: Fix #1538 #1579
Conversation
…s, added Emscripten jobs for building and testing
…omponents, added Emscripten jobs for building and testing" This reverts commit b24d632.
Basically, bake has no problems with static libraries, emscripten has almost zero support for -shared flag usage besides cmake There wasnt any need to update the codebase, just making sure emscriptten didnt panic when given warnings, not errors, solves the issue since changing the codebase according to emscriptten's desired sanity check results will always break the tests, as seen in my git commit history. @SanderMertens Finished the issue. |
…d ptrace, enable tests, and improve test output logging
@SanderMertens added further testing, mock commands are a must for compatibility to bake for emscripten. |
Bake also has no support for emscripten's backtracing, alongside with wasm system (had to use linux system via commands) alongside with execinfo.h (it was removed in 2014 from emscripten) and ptrace requirement (emscripten has its own backtracing) which is why we had to use mock ones, it compiles, however we cannot get full backtracing from test runs due to this incompability. |
Added a step that shows js files are generated and shows: as generated with their contents plus: |
Looks promising! One nit, why do test run show up multiple times here? https://github.com/SanderMertens/flecs/actions/runs/13373357366/job/37346911375 |
Ah! tee and cat were both used, that's why. I wanted to push all the buttons to get the output, fixing it. |
@SanderMertens should be fixed. |
LGTM! Thanks for the PR, the bounty should be added to your account soon, let me know if you run into any issues! |
Working on issue #1538