Skip to content

Completed: Fix #1538 #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Conversation

zelosleone
Copy link
Contributor

Working on issue #1538

@zelosleone
Copy link
Contributor Author

Basically, bake has no problems with static libraries, emscripten has almost zero support for -shared flag usage besides cmake There wasnt any need to update the codebase, just making sure emscriptten didnt panic when given warnings, not errors, solves the issue since changing the codebase according to emscriptten's desired sanity check results will always break the tests, as seen in my git commit history. @SanderMertens Finished the issue.

@zelosleone zelosleone marked this pull request as ready for review February 16, 2025 10:48
@zelosleone zelosleone changed the title WIP: Fix #1538 Completed: Fix #1538 Feb 16, 2025
…d ptrace, enable tests, and improve test output logging
@zelosleone
Copy link
Contributor Author

@SanderMertens added further testing, mock commands are a must for compatibility to bake for emscripten.

@zelosleone
Copy link
Contributor Author

zelosleone commented Feb 16, 2025

Bake also has no support for emscripten's backtracing, alongside with wasm system (had to use linux system via commands) alongside with execinfo.h (it was removed in 2014 from emscripten) and ptrace requirement (emscripten has its own backtracing) which is why we had to use mock ones, it compiles, however we cannot get full backtracing from test runs due to this incompability.

@zelosleone
Copy link
Contributor Author

Added a step that shows js files are generated and shows:
test_core_flecs.js and test_core_flecs_static.js
test_meta_flecs.js and test_meta_flecs_static.js
test_query_flecs.js and test_query_flecs_static.js
test_collections_flecs.js and test_collections_flecs_static.js
test_addons_flecs.js and test_addons_flecs_static.js
test_cpp_flecs.js and test_cpp_flecs_static.js

as generated with their contents plus:
./CMakeFiles/3.31.5/CompilerIdC/a.out.js
./CMakeFiles/3.31.5/CompilerIdCXX/a.out.js

@SanderMertens
Copy link
Owner

Looks promising! One nit, why do test run show up multiple times here? https://github.com/SanderMertens/flecs/actions/runs/13373357366/job/37346911375

@zelosleone
Copy link
Contributor Author

Looks promising! One nit, why do test run show up multiple times here? https://github.com/SanderMertens/flecs/actions/runs/13373357366/job/37346911375

Ah! tee and cat were both used, that's why. I wanted to push all the buttons to get the output, fixing it.

@zelosleone
Copy link
Contributor Author

@SanderMertens should be fixed.

@SanderMertens SanderMertens merged commit f31745f into SanderMertens:master Feb 19, 2025
73 checks passed
@SanderMertens
Copy link
Owner

LGTM! Thanks for the PR, the bounty should be added to your account soon, let me know if you run into any issues!

@zelosleone zelosleone deleted the issue-1538 branch February 19, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants