Skip to content

Conversation

Sandakan
Copy link
Owner

@Sandakan Sandakan commented Jun 2, 2024

Nora v3.1.0-stable Minor Update

whats-new-v3 1 0-stable

Note

This update includes experimental support for m4a and opus playback, LRCLIB lyrics, lyrics translations, bug fixes, and major performance improvements.

Changelog:

  • 🎉 New Features and Updates

  • 🔨 Fixes and Improvements

    • Fixed a bug where the correct lyrics line won't scroll to the center of the screen if the song is paused.
    • Fixed a bug where items in ArtistPage, AlbumPage, PlaylistPage, and GenrePage are not centered in their grid cells.
    • Fixed a bug where Discord Presence doesn't update as the player state changes. Fixes Discord RPC does not pause on Nora pause #244.
    • Fixed a bug where the sidebar shows a dynamic theme color in dark mode even though dynamic themes are disabled.
    • Fixed a bug where some views show light mode even though the dark mode is selected.
    • Fixed a bug where some buttons in the About section of the Settings page are misaligned.
    • Fixed a bug where non-library songs were not showing in Last.FM.
    • Fixed localization issue in LyricsPage title, not allowing changing lyrics offline/online status.
    • Fixed a bug where lyric metadata are lost when saving lyrics from lrclib to lrc files.
    • Fixed a bug where the first metadata line in LRC lyrics is considered a lyric line.
    • Fixed a bug where the app starts with the white splash even though the app is in dark mode. Fixes Use configured theme for splash screen #272.
    • Updated hyperlinks always to be underlined.
    • Fixed lyrics that were not updated on LyricsPage right after modifying them in LyricsEditingPage.
    • Fixed lyrics lines in LyricsEditingPage don't follow dynamic theme colors.
    • Fixed app name showing "Electron" instead of Nora. Fixes Bug: Window title is "Electron" #288.
    • Removed full-screen player that starts with lyrics showing.
    • Updated discord-rich-presence to display the current song position. Thanks @ElectroHeavenVN.
    • Fixed song filenames cut off at periods. Fixes Song (file?)names cut off at periods #308.
    • Added a fix for file names with special characters that cannot be played in Nora player. Fixes file name issue #323.
    • Set true to disable background artworks as default to improve app accessibility and to maintain text contrast.
    • Update font-family stack in styles.css for improved typography consistency.
    • Added an advanced settings section with an experimental setting to toggle saving verbose logs.
    • Fixed translated lyrics do not show their original lyric above them.
    • Added a fix for image alignment issues. Fixes [Bug] Alignment and Stutter issues in Albums Page #307.
    • Added a fix for the app description shown when Nora is viewed in Task Manager. Fixes Task Manager shows Nora Player as An Electron app with... #333.
    • Fixed the like button not working in the mini-player. Fixes Like button doesn't work #341.
    • Fixed incorrect song ordering in playlists. Fixes Playlist Song Oder #342.
    • Fixed the shuffle button not working and some shuffling issues. Fixes Shuttle Button not working #343.
  • 🚀 Development updates

    • Nora was fully converted to an ESM-packaged app.
    • Fixed some localization errors in the en.json file.
    • Updated the build workflow to fix a bug for the Nora app that is missing sharp dependencies in Linux environments.
    • Updated app dependencies.
  • 🐜 Known Issues and Bugs

Other Issues:

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally before submission with npm run lint and npm run prettier-write commands?
  • Have you successfully run the app with your changes locally with npm run dev?

Important

Fill the checklist items below to,

  • release a new update of the app
  • add an emergency change

Pull requests that directly modify the main branch should only fill the checklist items. > Delete if it's not the case.

  • Create a version artwork (if the update is minor or major).
  • Create and paste the artwork for the installer to the /build/installer_assets/sidebar.bmp directory.
  • Update the version entry in the package.json and package-lock.json files in the root directory.
  • Manage the changelog of this release
    • Copy the release notes from this PR and paste them to the changelog.md file.
    • Create a new versions entry in release-notes.json file.
      • Add the artworkPath to the entry.
      • Add relevant importantNotes to the entry.
      • Copy each release note, remove unnecessary items like markdown syntax, and add them to the new, fixed, and knownIssues sections separately in the notes entry.
      • Update these changes in that file's latestVersion entry.
      • Verify the file with the release-notes-schema.json file.
  • Update the readme.md file of the project
    • Update the release downloads badge URL with the created tag (same as the version entry in package.json) of the release.

- Updated the build workflow to fix a bug for Nora app missing sharp dependencies in Linux environments.
- Added experimental playback support for m4a and opus songs. Fixes #247, #242.
- Fully converted Nora to an ESM package.
- Added support for fetching lyrics from LRCLIB. Fixes #252.
- Fixed a bug where the correct lyrics line won't scroll to the center of the screen if the song is paused.
- Fixed a bug where items in ArtistPage, AlbumPage, PlaylistPage, GenrePage are not centered in their grid cells.
@Sandakan Sandakan added the 🎉 enhancement New feature or request label Jun 2, 2024
@Sandakan Sandakan self-assigned this Jun 2, 2024
@Sandakan Sandakan linked an issue Jun 2, 2024 that may be closed by this pull request
Brunight and others added 6 commits June 3, 2024 19:37
- Added support for reading LRC files without the relevant song extension.
- Discord Presence now updates as the player state changes.
- Refactored front-end codebase use destructured imports to improve build size and performance.
- Refactored all prompt menus to lazy load to improve performance.
- Fixed some localization errors in en.json file.
Add support for symbolic links
- Configured to build Nora in rpm and flatpak packages.
- Moved player related logic such as audio fade in/out to a new file.
- Fixed a bug where sidebar shows a dynamic theme color in dark mode even though dynamic themes are disabled.
- Fixed a bug where some views show light mode even though the dark mode is selected.
- Fixed some localization issues.
- Added support for copying lyrics lines.
- Fixed a bug where some buttons in the About section of the Settings page are misaligned.
@Sandakan Sandakan linked an issue Jun 15, 2024 that may be closed by this pull request
@Sandakan Sandakan removed a link to an issue Jun 15, 2024
@Sandakan Sandakan linked an issue Mar 4, 2025 that may be closed by this pull request
@Sandakan Sandakan linked an issue Mar 12, 2025 that may be closed by this pull request
@Sandakan Sandakan merged commit c53228b into master Mar 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment