Skip to content

Updated English translations (en.json) #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Updated English translations (en.json) #228

merged 2 commits into from
Jan 10, 2024

Conversation

JustCallMeQuincy
Copy link
Contributor

@JustCallMeQuincy JustCallMeQuincy commented Jan 9, 2024

Updated English translations

Copy link
Owner

@Sandakan Sandakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things we need to fix before merging.

"recentSearchResultTooltipLabel": "Search for '{{value}}'",
"showingResultsFor": "Showing results for <span>'{{query}}'</span>",
"showingResultsForWithFilter": "Showing results for <span>'{{query}}'</span> on <span>{{filter}}</span>",

"a": "Search for Anything"
"a": "Search for anything"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry is a mistake at my end. You can go ahead and remove the a entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's been merged, I don't have access to the PR so I'm afraid you'll have to remove it

@Sandakan Sandakan merged commit 1af8ce3 into Sandakan:translations Jan 10, 2024
Copy link
Contributor Author

@JustCallMeQuincy JustCallMeQuincy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once everything is changed, all looks good to me

"title": "Unsupported Audio File",
"description": "you are trying to open a file with a <span/> extension, which is not supported by this app.<br/> Currently, we only support following audio formats. <div/>"
"title": "Unsupported audio file",
"description": "You are trying to open a file with an<span/> extension, which is not supported by this app.<br/> Currently, we only support following audio formats. <div/>"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, in that case it should indeed be changed back (I have no access anymore so you go ahead)

"recentSearchResultTooltipLabel": "Search for '{{value}}'",
"showingResultsFor": "Showing results for <span>'{{query}}'</span>",
"showingResultsForWithFilter": "Showing results for <span>'{{query}}'</span> on <span>{{filter}}</span>",

"a": "Search for Anything"
"a": "Search for anything"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's been merged, I don't have access to the PR so I'm afraid you'll have to remove it

@JustCallMeQuincy JustCallMeQuincy deleted the patch-7 branch January 10, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants