-
Notifications
You must be signed in to change notification settings - Fork 35
Updated English translations (en.json) #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some things we need to fix before merging.
"recentSearchResultTooltipLabel": "Search for '{{value}}'", | ||
"showingResultsFor": "Showing results for <span>'{{query}}'</span>", | ||
"showingResultsForWithFilter": "Showing results for <span>'{{query}}'</span> on <span>{{filter}}</span>", | ||
|
||
"a": "Search for Anything" | ||
"a": "Search for anything" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry is a mistake at my end. You can go ahead and remove the a
entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's been merged, I don't have access to the PR so I'm afraid you'll have to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once everything is changed, all looks good to me
"title": "Unsupported Audio File", | ||
"description": "you are trying to open a file with a <span/> extension, which is not supported by this app.<br/> Currently, we only support following audio formats. <div/>" | ||
"title": "Unsupported audio file", | ||
"description": "You are trying to open a file with an<span/> extension, which is not supported by this app.<br/> Currently, we only support following audio formats. <div/>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, in that case it should indeed be changed back (I have no access anymore so you go ahead)
"recentSearchResultTooltipLabel": "Search for '{{value}}'", | ||
"showingResultsFor": "Showing results for <span>'{{query}}'</span>", | ||
"showingResultsForWithFilter": "Showing results for <span>'{{query}}'</span> on <span>{{filter}}</span>", | ||
|
||
"a": "Search for Anything" | ||
"a": "Search for anything" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's been merged, I don't have access to the PR so I'm afraid you'll have to remove it
Updated English translations