Skip to content

Nora v3.0 major update #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
May 10, 2024
Merged

Nora v3.0 major update #227

merged 35 commits into from
May 10, 2024

Conversation

Sandakan
Copy link
Owner

@Sandakan Sandakan commented Jan 5, 2024

Nora v3.0 major update

whats-new-v3 0 0-stable

Warning

Keep in mind that this major update will reset all previous app data.

Note

This update includes a full-screen player, dynamic themes, Turkish translations, bug fixes, and major performance improvements.

Changelog:

  • 🎉 New Features and Updates

    • Added an experimental full-screen player mode. Fixes Please add a full screen player , i have multi monitors it would look good if there is album art on one monitor in full screen #222.
    • Added support for translating lyrics. Fixes Lyrics Problem. #239.
    • Added support for dynamic themes based on the currently playing song.
    • Added experimental support auto-updating Nora.
    • Added support for navigation between prompts for supported prompts.
    • Greatly reduced unnecessary re-renders in turn improving overall performance.
    • Added a feature to prevent the display from going to sleep in situations with no user activity like displaying lyrics.
    • Moved notifications to the bottom right corner of the window.
    • Added support for Discord Rich Presence.
    • Added a progress bar to the bottom of the full-screen player.
    • Added keyboard shortcuts to control prompt menu back/forward navigation buttons.
    • Added Turkish translations. Thanks @mikropsoft.
    • Added support for filtering songs and artists in selected pages.
  • 🔨 Fixes and Improvements

    • Greatly improved palette generation duration. (90% faster)
    • Fixed some localization bugs in Nora.
    • Fixed a bug where Nora doesn't send albumArtist data when scrobbling songs.
    • Improved performance when sending scrobbling and now playing data to Last.fm.
    • Fixed a bug where albums related to artists are not shown.
    • Fixed a bug where special characters are not shown when localizing text in Nora.
    • Fixed a bug where metadata updates of songs outside the library fail.
    • Improved animations when displaying lyrics.
    • Fixed a bug where the auto-scrolling button in LyricsPage doesn't have a tooltip label.
    • Fixed a bug where the close button shows an incorrect tooltip label.
    • Updated English translations. Thanks @JustCallMeQuincy.
    • Added a CODE_OF_CONDUCT file to the repository.
    • Fixed a bug where buttons and dropdowns don't have enough contrast to read text when a background image is displayed.
    • ListeningActivityBarGraph now shows ListeningActivityBars according to the available width.
    • Added a possible fix to a missing dependency for Nora when launching in Linux-based operating systems.
    • Improved animations in notifications.
    • Fixed a bug where the app window would be hidden if the monitor it was in got disconnected.
    • Fixed a bug where app storage metrics show incorrect metrics when the app is installed in other than the C: drive.
    • Improved import playlist performance.
    • Fixed a bug where importing the Favorites playlist will make the app unresponsive due to many like/dislike notifications.
    • Fixed a bug where Nora will forget about sub-folders inside parent folders.
    • Improved app performance when displaying synced lyrics.
    • Fixed a bug where lyrics copyright info is positioned incorrectly in the full-screen player.
    • Fixed a bug where Nora doesn't check for LRC files in the custom LRC file path.
    • Fixed a bug where lyrics with the same timestamps don't appear correctly.
    • Fixed a bug where users can't change pages through the sidebar when the app language is changed to other than English.
    • Fixed showing the musixmatch disclaimer twice in the disclaimer dialog.
  • 🐜 Known Issues and Bugs

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally before submission with npm lint and npm run prettier-write commands?
  • Have you successfully run the app with your changes locally with npm run dev?

Important

Fill below checklist items to,

  • release a new update of the app
  • add an emergency change

Pull requests that directly modify the main branch should only fill the checklist items.
Delete if it's not the case.

  • Create a version artwork (if the update is minor or major).
  • Create and paste the artwork for the installer to the /build/installer_assets/sidebar.bmp directory.
  • Update the version entry in package.json and package-lock.json files in the root directory.
  • Manage the changelog of this release
    • Copy the release notes from this PR and paste them to the changelog.md file.
    • Create a new versions entry in release-notes.json file.
      • Add the artworkPath to the entry.
      • Add relevant importantNotes to the entry.
      • Copy each release note, remove unnecessary items like markdown syntax, and add them to the new, fixed, and knownIssues sections separately in the notes entry.
      • Update these changes also in the latestVersion entry in that file.
      • Verify the file with the release-notes-schema.json file.
  • Update the readme.md file of the project
    • Update the release downloads badge URL with the created tag (same as the version entry in package.json) of the release.

merge commits from master with minor-release
- Fixed some localization bugs in Nora.
- Fixed a bug where Nora doesn't send `albumArtist` data when scrobbling songs.
- Improved performance when sending scrobbling and now playing data to Last.fm.
- Fixed a bug where albums related to artists are not shown.
- Fixed a bug where special characters are not shown when localizing text in Nora.
-
- Added experimental support auto-updating Nora.
- Updated app dependencies.
- Added an experimental fullscreen player mode.
- Refactored main process ipc channels to a new file.
- Fixed a bug where metadata updates of songs outside the library fails.
- Improved animations when displaying lyrics.
- Fixed a bug where auto-scrolling button in LyricsPage doesn't have a tooltip label.
@Sandakan Sandakan added the 🎉 enhancement New feature or request label Jan 5, 2024
@Sandakan Sandakan self-assigned this Jan 5, 2024
@Sandakan Sandakan marked this pull request as ready for review January 7, 2024 07:34
@Sandakan Sandakan marked this pull request as draft January 7, 2024 07:35
Sandakan and others added 18 commits January 9, 2024 18:47
- Fixed a bug where prettier plugin doesn't sort tailwind class names.
- Sort tailwind class names.
- Updated dependencies.
- Updated to repository bug, pull-request and feature-request reports.
- Added a seek bar slider to the full-screen player.
- Moved seek bar sliders and volume sliders into seperate components to improve code reuse.
- Added a new animation where full-screen player changes showing sections between lyrics and music controls on mouse idle and active states.
- Fixed a bug where close button shows incorrect tooltip label.
- Added a new react hook to find if mouse is idle or acitve in a specified area.
Updated English translations (en.json)
- Added a CODE_OF_CONDUCT file to the repository.
- Fixed a bug in english translation file.
- Fixed a bug where buttons and dropdowns doesn't have enough contrast to read text in them when a background image is displayed.
- ListeningActivityBarGraph now shows ListeningActivityBars according the available width.
- Added a possible fix to a missing dependency for Nora when launching in linux based operating systems.
- Added a new test to check parseLyrics function.
- Fixed some issues in the english translation file.
- Added support for navigation between prompts for supported prompts.
- Added a feature to prevent the display from going to sleep in situations with no user activity like displaying lyrics.
- Fixed some bugs in the parseLyrics function.
- Moved notifications to the bottom right corner of the window.
- Updated outdated app dependencies.
- Added support for Discord Rich Presence.
- Refactored some test code.
- Improved animations in notifications.
- Updated app dependencies
- Updated app artworks to reflect possible app limitations.
- Fixed a bug where the app window will be hidden if the monitor it was in got disconnected.
- Fixed a bug where app storage metrics show incorrect metrics when the app is installed in other than the C: drive.
- Improved import playlist performance.
- Fixed a bug where importing the Favorites playlist will make the app unresponsive due to high number of like/dislike notifications.
- Fixed a bug where Nora will forget about sub-folders inside a parent folders.
- Improved app performance when displaying synced lyrics.
- Added a progress bar to the bottom of the full-screen player.
- Fixed a bug where lyrics copyright info are positioned incorrectly in the full-screen player.
- Added keyboard shortcuts to control prompt menu back/forward navigation buttons.
- Refactored path aliases to relative paths.
- Moved common files to a new /common directory
- Updated material icons.
- Greatly reduced unnecessary re-renders in turn improving overall performance.

Known Issues
- A delay is visible when syncing lyrics with keyboard shortcuts.
Migrated from Electron React Boilerplate to Electron Vite.
- Fixed prettier warnings.
- Fixed a bug related to importing 'didyoumean2' package.
- Removed .npmrc file
- Added support for dynamic themes based on currently playing song.
- Greatly improved palette generation duration. (90% faster)
- Moved artwork palettes to a different data storage.
@Sandakan Sandakan changed the title Nora v2.6.0-stable Minor update Nora v3.0 major update Mar 27, 2024
mikropsoft and others added 4 commits March 29, 2024 15:35
- Added improvements to dynamic themes.
- Updated workflows to run on Node 20.
- Fixed some localization issues.
- Removed themes generated from artist image when in ArtistInfoPage.
- Removed artist backgrounds from displaying in FullScreenPlayer background.
- Improved lyrics page errors.
- Reduced the size of the sidebar text.
Sandakan added 5 commits April 9, 2024 01:30
- Added Turkish translations.
- Added support for translating lyrics. Fixes #239.
- Added a new workflow to add VirusTotal results to published releases.
- Fixed a bug where Nora doesn't check for lrc files in the custom lrc file path.
- Fixed a bug where lyrics with same timestamps doesn't show up correctly.
- Updated fonts.
- Updated dynamic theming effects in Nora.
- Fixed a bug where users can't changes pages through side bar when the app language is changed to other than English.
- Fixed some eslint errors.
- Updated dependencies.
- Added experimental support for lyrics translations.
- Added support for filtering songs and artists in selected pages.
- Set a default zoom factor of 0.9 for Nora.
- Updated dropdowns to also include its type.
- Fixed some styles related to buttons.
- Fixed showing musixmatch disclaimer twice in the disclaimer dialog.
- Updated outdated dependencies.
- Removed prettier linting from github workflow temperorily to fix a bug failing the workflows.
- Pushed some files which should be included in the previous commit.
- Updated dynamic themes to also support dark theme.
- Added new covers for the upcoming update.
- Started using react-virtuso instead of react-window to display large lists.
- Fixed some styling issues related to dynamic themes.
@Sandakan Sandakan marked this pull request as ready for review May 4, 2024 10:00
Sandakan added 5 commits May 9, 2024 00:01
- Migrated to a newer package to handle rendering virtualized lists and grids.
- Fixed issues when scrolling with in grids with large number of items such as ArtistsPage.
- Fixed some styles related to sliders.
- Updated pull_request_template.
- Reverted back to old node version checking process in the build process.
- Fixed some song duration inconsistensies in the app.
- Added new translation strings.
- Removed a delay which was used previous when displaying lyrics.
@Sandakan Sandakan merged commit e319e1f into master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lyrics Problem. Please add a full screen player , i have multi monitors it would look good if there is album art on one monitor in full screen
3 participants