-
Notifications
You must be signed in to change notification settings - Fork 35
Nora v3.0 major update #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge commits from master with minor-release
- Fixed some localization bugs in Nora. - Fixed a bug where Nora doesn't send `albumArtist` data when scrobbling songs. - Improved performance when sending scrobbling and now playing data to Last.fm. - Fixed a bug where albums related to artists are not shown. - Fixed a bug where special characters are not shown when localizing text in Nora. -
- Added experimental support auto-updating Nora. - Updated app dependencies. - Added an experimental fullscreen player mode. - Refactored main process ipc channels to a new file. - Fixed a bug where metadata updates of songs outside the library fails. - Improved animations when displaying lyrics. - Fixed a bug where auto-scrolling button in LyricsPage doesn't have a tooltip label.
- Fixed a bug where prettier plugin doesn't sort tailwind class names. - Sort tailwind class names. - Updated dependencies. - Updated to repository bug, pull-request and feature-request reports. - Added a seek bar slider to the full-screen player. - Moved seek bar sliders and volume sliders into seperate components to improve code reuse. - Added a new animation where full-screen player changes showing sections between lyrics and music controls on mouse idle and active states. - Fixed a bug where close button shows incorrect tooltip label. - Added a new react hook to find if mouse is idle or acitve in a specified area.
Updated English translations (en.json)
- Added a CODE_OF_CONDUCT file to the repository. - Fixed a bug in english translation file. - Fixed a bug where buttons and dropdowns doesn't have enough contrast to read text in them when a background image is displayed. - ListeningActivityBarGraph now shows ListeningActivityBars according the available width.
- Added a possible fix to a missing dependency for Nora when launching in linux based operating systems. - Added a new test to check parseLyrics function. - Fixed some issues in the english translation file. - Added support for navigation between prompts for supported prompts. - Added a feature to prevent the display from going to sleep in situations with no user activity like displaying lyrics. - Fixed some bugs in the parseLyrics function. - Moved notifications to the bottom right corner of the window.
- Updated outdated app dependencies. - Added support for Discord Rich Presence. - Refactored some test code. - Improved animations in notifications.
- Updated app dependencies - Updated app artworks to reflect possible app limitations. - Fixed a bug where the app window will be hidden if the monitor it was in got disconnected. - Fixed a bug where app storage metrics show incorrect metrics when the app is installed in other than the C: drive. - Improved import playlist performance. - Fixed a bug where importing the Favorites playlist will make the app unresponsive due to high number of like/dislike notifications. - Fixed a bug where Nora will forget about sub-folders inside a parent folders. - Improved app performance when displaying synced lyrics. - Added a progress bar to the bottom of the full-screen player. - Fixed a bug where lyrics copyright info are positioned incorrectly in the full-screen player. - Added keyboard shortcuts to control prompt menu back/forward navigation buttons.
- Refactored path aliases to relative paths. - Moved common files to a new /common directory
- Updated material icons. - Greatly reduced unnecessary re-renders in turn improving overall performance. Known Issues - A delay is visible when syncing lyrics with keyboard shortcuts.
Migrated from Electron React Boilerplate to Electron Vite.
- Fixed prettier warnings. - Fixed a bug related to importing 'didyoumean2' package. - Removed .npmrc file
- Added support for dynamic themes based on currently playing song. - Greatly improved palette generation duration. (90% faster) - Moved artwork palettes to a different data storage.
- Added improvements to dynamic themes. - Updated workflows to run on Node 20. - Fixed some localization issues. - Removed themes generated from artist image when in ArtistInfoPage. - Removed artist backgrounds from displaying in FullScreenPlayer background. - Improved lyrics page errors. - Reduced the size of the sidebar text.
Add turkish locales
- Added Turkish translations. - Added support for translating lyrics. Fixes #239. - Added a new workflow to add VirusTotal results to published releases. - Fixed a bug where Nora doesn't check for lrc files in the custom lrc file path. - Fixed a bug where lyrics with same timestamps doesn't show up correctly. - Updated fonts. - Updated dynamic theming effects in Nora. - Fixed a bug where users can't changes pages through side bar when the app language is changed to other than English.
- Fixed some eslint errors. - Updated dependencies. - Added experimental support for lyrics translations. - Added support for filtering songs and artists in selected pages. - Set a default zoom factor of 0.9 for Nora. - Updated dropdowns to also include its type. - Fixed some styles related to buttons. - Fixed showing musixmatch disclaimer twice in the disclaimer dialog.
- Updated outdated dependencies. - Removed prettier linting from github workflow temperorily to fix a bug failing the workflows. - Pushed some files which should be included in the previous commit.
- Updated dynamic themes to also support dark theme. - Added new covers for the upcoming update. - Started using react-virtuso instead of react-window to display large lists. - Fixed some styling issues related to dynamic themes.
- Migrated to a newer package to handle rendering virtualized lists and grids. - Fixed issues when scrolling with in grids with large number of items such as ArtistsPage. - Fixed some styles related to sliders.
- Updated pull_request_template. - Reverted back to old node version checking process in the build process. - Fixed some song duration inconsistensies in the app. - Added new translation strings. - Removed a delay which was used previous when displaying lyrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nora v3.0 major update
Warning
Keep in mind that this major update will reset all previous app data.
Note
This update includes a full-screen player, dynamic themes, Turkish translations, bug fixes, and major performance improvements.
Changelog:
🎉 New Features and Updates
🔨 Fixes and Improvements
albumArtist
data when scrobbling songs.LyricsPage
doesn't have a tooltip label.🐜 Known Issues and Bugs
Checklist:
npm lint
andnpm run prettier-write
commands?npm run dev
?Important
Fill below checklist items to,
Pull requests that directly modify the
main
branch should only fill the checklist items.Delete if it's not the case.
version
entry inpackage.json
andpackage-lock.json
files in the root directory.versions
entry in release-notes.json file.artworkPath
to the entry.importantNotes
to the entry.new
,fixed
, andknownIssues
sections separately in thenotes
entry.latestVersion
entry in that file.release downloads
badge URL with the created tag (same as theversion
entry in package.json) of the release.