use github API to commit - which might make commits show up as verified? #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 76 76
Lines 1650 1650
=======================================
Hits 1599 1599
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release workflow to create commits via the GitHub API, ensuring they appear as verified as part of the CD process.
- Clarifies fetch-depth requirement for API operations
- Replaces direct
git commit/pushwith API-based commit and ref update - Adds JSON parsing and error handling around the API calls
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:131
- The workflow uses
jqto parse JSON but does not install it. Consider adding a step to installjqbefore using it or switch to a parser available on the runner.
NEW_SHA=$(echo "$COMMIT_RESPONSE" | jq -r '.sha')
.github/workflows/release.yml:106
- [nitpick] This block of raw
curlcommands is lengthy and can be harder to maintain. You could simplify and maintain this logic usingactions/github-scriptor the GitHub CLI (gh api).
COMMIT_RESPONSE=$(curl -s -f -X POST \
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to make commits made by CD show up as verified.