Fix signing of commits #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines the release process by removing the old cargo-release configuration and switching to cargo-set-version for version bumps while ensuring commits are properly signed by the bot.
- Drops the
.release.tomlfile and allcargo-releasesettings. - Updates the GitHub Actions workflow to install
cargo-edit, bump versions withcargo set-version, and handle bot identity during commits. - Adds a conditional to skip empty commits when no version change is detected.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.release.toml |
Removed legacy cargo-release configuration. |
.github/workflows/release.yml |
Replaced cargo-release steps with cargo-edit, set up Git identity, and added conditional commit logic. |
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:84
- To ensure commits are GPG-signed in CI, add
git config commit.gpgsign trueand specify the signing key (e.g.,git config user.signingkey <KEY_ID>) before thegit commitstep.
git config user.name "github-actions[bot]"
.github/workflows/release.yml:72
- [nitpick] Consider caching the
cargo-editinstallation (usingactions/cacheor a pre-built tool container) to speed up workflow runs and avoid reinstalling on every execution.
run: cargo install cargo-edit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 76 76
Lines 1650 1650
=======================================
Hits 1599 1599
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.