try fix release #16
Merged
try fix release #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the non-existent taiki-e/setup-cross CI step with a cache-based install of the cross binary.
- Removes the
taiki-e/setup-crossaction - Adds cache restore and conditional install steps for
cross
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:118
- The indentation of the new steps doesn’t match the surrounding steps under
jobs.*.steps, which will cause the YAML to fail parsing. Align these- name:lines with the existing steps (e.g., use the same number of spaces).
- name: Restore cross cache
.github/workflows/release.yml:123
- [nitpick] The cache key only includes the
Cargo.lockhash. If you ever bump thecrossversion, the cache won’t be invalidated. Consider adding a version identifier (e.g.,-cross-v1) to the key so updates tocrossbust the cache.
key: ${{ runner.os }}-cross-${{ hashFiles('**/Cargo.lock') }}
.github/workflows/release.yml:126
- [nitpick] For reproducible installs, include the
--lockedflag (i.e.,cargo install --locked cross) so it respectsCargo.lockand avoids unexpected version changes.
run: cargo install cross
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 76 76
Lines 1650 1650
=======================================
Hits 1599 1599
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a non existent CI step.