CD: Brew prebuilt binaries for macOS Apple Silicon and Linux. #15
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 76 76
Lines 1648 1650 +2
=======================================
+ Hits 1597 1599 +2
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Add support for Homebrew prebuilt binaries by extending CI workflows to build, release, and publish macOS (Apple Silicon) and Linux artifacts without requiring local Rust installation.
- Introduce a reusable
setup-sccacheaction for caching Rust compilation - Update release workflow to generate, package, and upload binaries, then update Homebrew formula
- Rename and refactor release steps into
create-release,build-and-upload, andupdate-homebrewjobs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Added Setup sccache steps before Rust toolchain installs |
| .github/workflows/release.yml | Refactored release flow: added sccache, split release jobs, asset build, and Homebrew update |
| .github/actions/setup-sccache/action.yml | New composite action to install, configure, and cache sccache |
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:51
- The indentation of
create-release:does not match other job definitions underjobs:. Please align it with the same indent level as other job entries to avoid YAML parsing errors.
create-release:
.github/workflows/test.yml:32
- [nitpick] For consistency with the existing
Set up Ruststep, consider renaming this step toSet up sccache(two words) to match the verb-noun pattern.
- name: Setup sccache
.github/workflows/test.yml:32
- [nitpick] The
setup-sccachestep is duplicated across multiple workflows; you could DRY this by using workflow templates, composite actions, or YAML anchors to reduce repetition.
- name: Setup sccache
Add support for homebrew but without the need for users to have Rust installed thanks to prebuilt binaries for macOS (Apple Silicon support only, Intel is being phased out) and Linux.
Publishing formula updates to https://github.com/Sajjon/homebrew-klirr