Fix react-markdown component names #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e80d376.
And fix change to treatment of text nodes
This allows us to go all the way up to 8.0.0 without the breakages from before.
yongxin12
pushed a commit
to yongxin12/Sabaki-web-test
that referenced
this pull request
Aug 30, 2025
* Revert "Bump react-markdown from 3.6.0 to 8.0.3 (SabakiHQ#865)" This reverts commit e80d376. * Bump react-markdown incrementally to 4.0.0 And fix change to treatment of text nodes * Adapt to react-markdown 6.0.0 breaking changes This allows us to go all the way up to 8.0.0 without the breakages from before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API change in react-markdown 6.0.0 was a little deeper than I though, the renderers need to be converted to "components" according to their HTML entity types rather than their abstract markdown names.
Fixes #898.