Fix layout of edit mode when comment box is hidden #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for diving in with this! After a bunch of investigation, I can't really find a cleaner way of accomplishing this either - so thank you so much for this implementation :) |
yongxin12
pushed a commit
to yongxin12/Sabaki-web-test
that referenced
this pull request
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the comment box is hidden and edit mode is being turned on, the layout and therefore the mouse event handling on the game graph gets messed up (offset by some amount).
I fixed that.
Be aware that I am not very experienced with react, so I don't know if this is the best way of doing this.
Cheers