Call spawn with absolute path if the file exists, or relative path if it doesn't #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yishn
reviewed
Apr 18, 2020
src/modules/enginesyncer.js
Outdated
Comment on lines
91
to
98
| let fileExistsSync = path => { | ||
| try { | ||
| fs.accessSync(path, fs.F_OK) | ||
| return true | ||
| } catch { | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not simply use fs.existsSync()?
There was a problem hiding this comment.
My understanding is that fs.existsSync is deprecated, but that information was outdated. I modified it to use fs.existsSync. Thanks
|
Thanks a lot for your PR! |
yongxin12
pushed a commit
to yongxin12/Sabaki-web-test
that referenced
this pull request
Aug 30, 2025
… it doesn't (SabakiHQ#698) * Call spawn with absolute path if the file exists, or relative path if it doesn't. * Use fs.existsSync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #695