Skip to content

Change type of 'effect_apply_type' to 'uint8_t' #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

Change type of 'effect_apply_type' to 'uint8_t' #1716

merged 1 commit into from
Nov 25, 2024

Conversation

heinezen
Copy link
Member

Follow up to #1712 (comment)

This changes the signage of effect_apply_type to unsigned (uint8) as genieutils also uses this type.

@heinezen heinezen added improvement Enhancement of an existing component lang: python Done in Python code area: assets Involved with assets (images, sounds, ...) labels Nov 25, 2024
@heinezen heinezen added this to the 0.6.0 milestone Nov 25, 2024
@TheJJ TheJJ merged commit 1b763cc into SFTtech:master Nov 25, 2024
13 checks passed
@heinezen heinezen deleted the fix/effect_apply_type branch November 25, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
area: assets Involved with assets (images, sounds, ...) improvement Enhancement of an existing component lang: python Done in Python code
Projects
openage converter
Status: ✅ Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@heinezen @TheJJ