Fix version tag regex failure when HEAD is tagged #1583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJJ
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our buildsystem expects version tags in the format
v1.2.3-4-g00abcdef(tag + commit distance to tag + commit hash). However, since #1576 we callgit describe --tags. WhenHEADis tagged, this command only outputs the tag and omits commit distance and commit hash (onlyv1.2.3is returned). This results in a configure failure since our regex cannot match the version format in this case.This PR switches the version fetch command to
git describe --tags --long, so that the long format is always used.