Skip to content

Fix out of bound access in matrix constructor #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fix out of bound access in matrix constructor #1570

merged 2 commits into from
Oct 11, 2023

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Oct 9, 2023

Fixes #1568

The previous version calculated the insertion indices incorrectly but the values were still placed at the correct memory addresses. That's why the tests ran through but _GLIBCXX_ASSERTIONS complained.

@heinezen heinezen added lang: c++ Done in C++ code bugfix Restores intended behavior labels Oct 9, 2023
@heinezen heinezen mentioned this pull request Oct 9, 2023
Closed
@heinezen heinezen changed the title Fix out of bound acces in matrix constructor Fix out of bound access in matrix constructor Oct 10, 2023
@TheJJ TheJJ merged commit 9fe3672 into SFTtech:master Oct 11, 2023
@heinezen heinezen deleted the fix/matrix-bounds branch October 20, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
bugfix Restores intended behavior lang: c++ Done in C++ code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test fail when building with GCC 13.2.1
2 participants
@heinezen @TheJJ