Skip to content

Make asset location cache file write more robust #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2023
Merged

Make asset location cache file write more robust #1561

merged 2 commits into from
Oct 8, 2023

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Oct 6, 2023

Fixes #1557

  • Raise IOError if we get an invalid handle on open
  • Skip asset location write if the file cannot be accessed

@heinezen heinezen added area: assets Involved with assets (images, sounds, ...) bugfix Restores intended behavior labels Oct 6, 2023
TheJJ
TheJJ reviewed Oct 7, 2023
View reviewed changes
@heinezen heinezen force-pushed the fix/asset-location-cache branch 2 times, most recently from 7cc9036 to e0dbc42 Compare October 7, 2023 11:52
@heinezen heinezen force-pushed the fix/asset-location-cache branch from e0dbc42 to eec461e Compare October 7, 2023 12:43
@heinezen heinezen added the lang: python Done in Python code label Oct 7, 2023
@TheJJ TheJJ merged commit 688255c into SFTtech:master Oct 8, 2023
@heinezen heinezen deleted the fix/asset-location-cache branch October 8, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
area: assets Involved with assets (images, sounds, ...) bugfix Restores intended behavior lang: python Done in Python code
Projects
openage converter
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset conversion issue, AttributeError: 'NoneType' object has no attribute 'readable'
2 participants
@heinezen @TheJJ