Supports HDR encoding on Apple ImageIO coder #3799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just forward the options, no extra logic
this need iOS 18 and macOS 15 device (not simulator)
|
@CloudlessMoon Have a check I think this simple change is OK. If your input CGImage is directly from ImageIO HDR decoded result, the encoding usage is simple We don't support custom gain map or complicated encoding currently, just allows for simplest case |
dreampiggy
commented
Feb 22, 2025
bd096a1 to
bc1c108
Compare
bc1c108 to
ba8b93f
Compare
…raw int value 0/1/2
ea954c8 to
a4dba8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This just forward the options, no extra logic, really simple changes
To test Apple ImageIO HDR encoding, you need iOS 18 and macOS 15 device (not simulator)