Skip to content

Conversation

dreampiggy
Copy link
Contributor

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

This can close #3742

and also workaround that strange JFIF image bug in #3594

@dreampiggy dreampiggy force-pushed the bugfix/fix_jfif_orientation_new_solution branch from 4a686f1 to 494a5ca Compare August 21, 2024 09:43
@dreampiggy dreampiggy added apple bug apple's bug cause our framework author's pain ImageIO Anything related to Apple ImageIO codec labels Aug 21, 2024
@dreampiggy dreampiggy changed the title Use the new way to detect JFIF, and do not apply EXIF orientation to workaround Apple's bug Fix the thumbnail decoding on JPEG which contains EXIF orientation, use the new way to workaround JFIF bug Aug 21, 2024
@dreampiggy dreampiggy force-pushed the bugfix/fix_jfif_orientation_new_solution branch from 494a5ca to 1274d89 Compare August 21, 2024 10:57
@dreampiggy dreampiggy force-pushed the bugfix/fix_jfif_orientation_new_solution branch from 1274d89 to 95401e3 Compare August 21, 2024 12:36
@dreampiggy dreampiggy merged commit 0a4f92c into SDWebImage:master Aug 22, 2024
5 of 7 checks passed
@dreampiggy dreampiggy deleted the bugfix/fix_jfif_orientation_new_solution branch August 22, 2024 07:28
@dreampiggy dreampiggy added this to the 5.19.7 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple bug apple's bug cause our framework author's pain ImageIO Anything related to Apple ImageIO codec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

used SDWebImage to load the following image link, I found that some **thumbnail** JPEG image was rotated on iOS, but normal in the browser
1 participant