Use the better way to detect lazy/non-lazy CGImage. Only do force decoding for lazy image (avoid thumbnail image been decoded twice) #3736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oding for lazy image This effect the thumbnail decoding (which produce non-lazy CGImage, but accidentally been force decoded)
d614e56 to
ecedea2
Compare
Naveen-C-Ramachandrappa
approved these changes
Aug 7, 2024
b819533 to
0df663c
Compare
dreampiggy
commented
Aug 7, 2024
| @@ -123,11 +123,7 @@ - (void)testSDGraphicsImageRenderer { | |||
| #endif | |||
| expect(format.scale).equal(screenScale); | |||
| expect(format.opaque).beFalsy(); | |||
| #if SD_UIKIT | |||
There was a problem hiding this comment.
This test case changes is because of #3735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This effect the thumbnail decoding (which produce non-lazy CGImage, but accidentally been force decoded)