Remove the extra memory warning notification for AutoPurgeCache #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2153 +/- ##
==========================================
- Coverage 81.24% 80.26% -0.99%
==========================================
Files 36 35 -1
Lines 3690 3451 -239
Branches 345 306 -39
==========================================
- Hits 2998 2770 -228
+ Misses 669 659 -10
+ Partials 23 22 -1
Continue to review full report at Codecov.
|
mythodeia
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / reffers to the following issues: #1594
Pull Request Description
The
AutoPurgeCachewhich add a notification forUIApplicationDidReceiveMemoryWarningNotificationis useless becauseSDImageCacheitself has already add a notifiacation for this. And will actually call[self.memCache removeAllObjects];So we do not need to trigger clean twice. :)