Skip to content

Upgrade to Babel 6.x #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2016
Merged

Upgrade to Babel 6.x #953

merged 4 commits into from
Mar 29, 2016

Conversation

scttcper
Copy link
Contributor

Babel 6 requires es2015 preset package. Decided to use the babel-loader query string, could also use a .babel-rc file. https://github.com/babel/babel-loader#options

@Swiip
Copy link
Owner

Swiip commented Mar 28, 2016

Nice, can you rebase it ? (sorry for the huge delay)

@scttcper
Copy link
Contributor Author

@Swiip rebased and tests are passing again.

@Swiip
Copy link
Owner

Swiip commented Mar 29, 2016

awesome!

@Swiip Swiip merged commit 76e8744 into Swiip:master Mar 29, 2016
@scttcper scttcper deleted the babel6 branch March 29, 2016 05:18
@pablorsk
Copy link
Contributor

Your work is awesome!

gulp serve work fine, but gulp dist generate a project but don't work fine, console show this error:

Error: [$injector:strictdi] o is not using explicit annotation and cannot be invoked in strict mode

Any ideas?

@scttcper
Copy link
Contributor Author

@pablorsk sounds like you're having issues with ngInject
Make sure you have ng-strict-di enabled and that you have 'ngInject' at the top of your controllers.

@pablorsk
Copy link
Contributor

hi @scttcper!

I have ng-strict-di on element. but with babel5 work all with /** @ngInject */ before all function with injections. Need I add 'ngInject' on all files? My question is only becouse now with babel5 is working.

Regards...

@scttcper
Copy link
Contributor Author

scttcper commented Jul 14, 2016

Depends what version of nginject you're using. Either way, that's where I would start looking for your issue.

Edit: or babel 6 broke the version of nginject you're using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants