Style/typescript improvements #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, to prevent errors in tools like VS Code
…s constructor vars in tslint
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two little changes.
First in Visual Studio Code although having installed angular typings using tsd it refused to recognise ng.* declarations. Looking through the actual d.ts file, I noticed that ng is an alias for angular.
Replacing ng.* with angular.* fixed the issue and Visual Studio, WebStorm and Atom are all happy with it. Not sure why it is not picking it up, bug angular.* seems more correct anyway (apart from the extra space it takes).
Secondly, typescript has a nice shorthand for declaring class properties for constructor parameters which cleans up the code a bit (produced js is identical) and thought it would nice to use them in your templates.