Changed TypeScript index.module classes to functions #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm 👍 |
|
@mikesigs Do you have already written unit test in TypeScript with Karma ? I look for help or a good example. |
|
Just a question, if we change the type from class to function, shouldn't we change the first character of the name of a lower case? |
|
Agree |
|
I lower-cased the function names. @zckrs No, I'm afraid that's not something I've tackled yet. But I agree, there aren't too many great examples out there. |
|
Can you fix our test at https://github.com/Swiip/generator-gulp-angular/blob/master/test/template/test-index-module-js.js#L57 ? |
|
Thanks zckrs. It's fixed now. Really wish I could get these tests to work locally. Sorry about that. |
|
No problem :-) Travis ensure. |
zckrs
pushed a commit
that referenced
this pull request
Jun 26, 2015
Changed TypeScript index.module classes to functions
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #629.
index.ts was split into several files: index.module.ts, index.config.ts, index.route.ts, and index.run.ts. The last three files in that list each defined classes to encapsulate their functionality. However, in the index.module.ts, the classes were being passed to the angular module.config() and module.run(), but Angular doesn't call these functions with the new keyword, meaning they should just be functions. Having them as classes didn't actually break anything, but when trying to use
thisin the constructor, you gotundefined(in strict mode) orwindowotherwise. Changing these implementations to justexport functionwill prevent devs from writing code as though it's a constructor.