Skip to content

Refacto test sample #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 25, 2015
Merged

Refacto test sample #598

merged 15 commits into from
Jun 25, 2015

Conversation

zckrs
Copy link
Collaborator

@zckrs zckrs commented Jun 11, 2015

Rewrite unit test with Karma

  • Add test in plain Javascript with 98% coverage
  • Enable coverage report for plain Javascript and Coffescript
  • Add sample test in Coffescript
  • Add sample test in ES6 (actually not written in ES6 _main.controller.spec.es6)
  • Add sample test in Typescript (actually not written in Typescript _main.controller.spec.ts)

Coverage report for plain Javascript
coverage-plain-js

@zckrs
Copy link
Collaborator Author

zckrs commented Jun 24, 2015

@Swiip I don't understand why last inception test failed with custom path option

[src:src/angular/app e2e:tests/e2e dist:target/build/folder tmp:.tmp/folder]

Error is:
Error: Unexpected request: GET app/components/navbar/navbar.html

I suspect a problem with karma-ng-html2js-preprocessor and angular $templateCache

Help appreciate :-(

@zckrs zckrs changed the title [WIP] Refacto test sample Refacto test sample Jun 24, 2015
@Swiip
Copy link
Owner

Swiip commented Jun 24, 2015

For the templates un karma de use a plugin karmaHtml2Js. Look at the karma conf the path of sources ils hardcoded. Your new tests actually already finds a bug.

@zckrs
Copy link
Collaborator Author

zckrs commented Jun 25, 2015

🎉 thank you

@Swiip
Copy link
Owner

Swiip commented Jun 25, 2015

👍 👍

Swiip added a commit that referenced this pull request Jun 25, 2015
@Swiip Swiip merged commit c926a4f into Swiip:master Jun 25, 2015
@zckrs zckrs mentioned this pull request Jun 25, 2015
@zckrs zckrs deleted the refacto-test-sample branch September 9, 2015 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants