Make β generic for FloatingPoint values #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
- Coverage 92.85% 92.84% -0.01%
==========================================
Files 100 100
Lines 3427 3424 -3
==========================================
- Hits 3182 3179 -3
Misses 245 245
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Generated by π« Danger |
| @@ -81,3 +81,15 @@ public prefix func Β± <T: FloatingPoint> (number: T) -> (T, T) { | |||
| return 0 Β± number | |||
| } | |||
| // swiftlint:enable identifier_name | |||
|
|
|||
| // swiftlint:disable identifier_name | |||
There was a problem hiding this comment.
I think that would be a good thing to add those exceptions on the swiftlint.yaml file ... common cases like those to avoid this bunch of enable disable ... no in this PR though, might be good for an issue with starter task :)
| /// | ||
| /// - Parameter float: float value to find square root for | ||
| /// - Returns: square root of given float. | ||
| public prefix func β<T> (float: T) -> T where T: FloatingPoint { |
There was a problem hiding this comment.
I wonder if its time to think about inline such trivial numeric operators like this, the implementation is trivial so maybe we should throw an @inlinable here (and possibly audit other places where we could do it as well). This is good especially for generic functions like this one because it would allow the compiler to specialize such functions on clients that install this library as a module.
LucianoPAlmeida
approved these changes
Jul 21, 2020
nasircsms
pushed a commit
to nasircsms/SwifterSwift
that referenced
this pull request
Aug 26, 2020
* 'master' of https://github.com/SwifterSwift/SwifterSwift: (79 commits) Helper functions for scrolling to the edges or by page of a scroll view (SwifterSwift#888) Add XCTest extension for comparing Color objects (SwifterSwift#889) Fix swiftlint error (SwifterSwift#894) Bump kramdown from 2.1.0 to 2.3.0 (SwifterSwift#891) Added note for UIView.addShadow() (SwifterSwift#890) loadFromNib(withClass) (SwifterSwift#885) constraint finders (widthConstraint, heightConstraint, leadingConstraint, trailingConstraint, topConstraint, bottomConstraint) (SwifterSwift#886) added String.regexEscaped (SwifterSwift#883) Make β generic for FloatingPoint values (SwifterSwift#880) Update UITextField extensions (SwifterSwift#878) Added `masksToBounds` (IBInspectable) extension (SwifterSwift#877) Reinstate debounce function (SwifterSwift#869) `RandomAccessCollection`/`Collection` generalisations (SwifterSwift#863) Added HKActivitySummary extensions (SwifterSwift#875) Added new method for easily instantiating a view controller from a storyboard (SwifterSwift#860) Clean up code (SwifterSwift#864) fixed "".truncated crashed (SwifterSwift#866) Deprecated map(by:), compactMap(by:), filter(by:) (SwifterSwift#862) Overloaded 'contains' operator for string regex matching (SwifterSwift#858) Added convenient wrapper to asyncAfter (SwifterSwift#859) ... # Conflicts: # Sources/SwifterSwift/AppKit/NSColorExtensions.swift # Sources/SwifterSwift/AppKit/NSImageExtensions.swift # Sources/SwifterSwift/AppKit/NSViewExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGColorExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGFloatExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGPointExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGSizeExtensions.swift # Sources/SwifterSwift/Foundation/NSAttributedStringExtensions.swift # Sources/SwifterSwift/SwiftStdlib/StringExtensions.swift # SwifterSwift.xcodeproj/project.pbxproj # Tests/AppKitTests/NSColorExtensionsTests.swift # Tests/SwiftStdlibTests/StringExtensionsTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π
The underlying function is generic, so might as well do the same.
Checklist
@availableif not.