Update UITextField extensions #878

Jayxiang · 2020-07-13T03:38:01Z

Update UITextField extensions,fixed UITextField addPaddingLeftIcon doesn't work on iOS 13(#876 ),Also I added addPaddingRight,addPaddingRightIcon;and testAddPaddingRight,testAddPaddingImageRightIcon

Checklist

I checked the Contributing Guidelines before creating this request.
New extensions are written in Swift 5.0.
New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
I have added tests for new extensions, and they passed.
All extensions have a clear comments explaining their functionality, all parameters and return type in English.
All extensions are declared as public.
I have added a changelog entry describing my changes.

Update UITextField extensions,fixed UITextField addPaddingLeftIcon doesn't work on iOS 13,add addPaddingRight,addPaddingRightIcon

codecov · 2020-07-13T03:46:23Z

Codecov Report

Merging #878 into master will increase coverage by 2.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   92.82%   95.61%   +2.78%     
==========================================
  Files         100       97       -3     
  Lines        3415     3328      -87     
==========================================
+ Hits         3170     3182      +12     
+ Misses        245      146      -99

Flag	Coverage Δ
#ios	`95.61% <100.00%> (+0.01%)`	⬆️
#macos	`?`
#tvos	`93.60% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ces/SwifterSwift/UIKit/UITextFieldExtensions.swift	`100.00% <100.00%> (ø)`
...ources/SwifterSwift/AppKit/NSImageExtensions.swift
...ources/SwifterSwift/AppKit/NSColorExtensions.swift
Sources/SwifterSwift/AppKit/NSViewExtensions.swift
...ces/SwifterSwift/Shared/EdgeInsetsExtensions.swift	`100.00% <0.00%> (+13.51%)`	⬆️
.../SwifterSwift/CoreGraphics/CGColorExtensions.swift	`100.00% <0.00%> (+50.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055732c...33ba375. Read the comment docs.

Sources/SwifterSwift/UIKit/UITextFieldExtensions.swift

guykogus

Hey, thanks for fixing this. Left you a few notes.
Also, don't forget to add a CHANGELOG entry.

Sources/SwifterSwift/UIKit/UITextFieldExtensions.swift

guykogus · 2020-07-17T09:21:02Z

Sources/SwifterSwift/UIKit/UITextFieldExtensions.swift

+        let paddingView = UIView(frame: CGRect(x: 0, y: 0, width: padding, height: frame.height))
+        rightView = paddingView


There's no need to do this in 2 steps. Also, you should be using bounds, not frame.

Suggested change

let paddingView = UIView(frame: CGRect(x: 0, y: 0, width: padding, height: frame.height))

rightView = paddingView

rightView = UIView(frame: CGRect(x: 0, y: 0, width: padding, height: bounds.height))

Feel free to fix the function above too.

Tests/UIKitTests/UITextFieldExtensionsTests.swift

Co-authored-by: Guy Kogus <guy.kogus@gmail.com>

SwifterSwiftBot · 2020-07-17T10:39:34Z

	4 Messages
📖	Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.
📖	iOS: Executed 687 tests, with 0 failures (0 unexpected) in 22.138 (23.839) seconds
📖	tvOS: Executed 649 tests, with 0 failures (0 unexpected) in 4.526 (5.246) seconds
📖	macOS: Executed 512 tests, with 0 failures (0 unexpected) in 3.905 (4.183) seconds

Generated by 🚫 Danger

guykogus · 2020-07-17T10:42:34Z

Tests/UIKitTests/UITextFieldExtensionsTests.swift

+        textfield.frame = CGRect(x: 0, y: 0, width: 100, height: 44)
+
+        let bundle = Bundle(for: UIImageExtensionsTests.self)
+        let image = UIImage(named: "TestImage", in: bundle)!


My bad, I thought the parameter was optional.

Suggested change

let image = UIImage(named: "TestImage", in: bundle)!

let image = UIImage(named: "TestImage", in: bundle, compatibleWith: nil)!

guykogus · 2020-07-17T10:44:17Z

Sources/SwifterSwift/UIKit/UITextFieldExtensions.swift

+        rightView = paddingView
+        rightViewMode = .always
+    }
+


You can set your Xcode Editing settings to trim whitespace lines. This will help avoid SwiftLint errors.

Suggested change

guykogus · 2020-07-17T10:44:27Z

Sources/SwifterSwift/UIKit/UITextFieldExtensions.swift

        leftViewMode = .always
    }
+


Suggested change

guykogus · 2020-07-17T10:44:37Z

Tests/UIKitTests/UITextFieldExtensionsTests.swift

+        textfield.addPaddingRight(40)
+        XCTAssertEqual(textfield.rightView?.frame.width, 40)
+    }
+


Suggested change

guykogus · 2020-07-17T11:00:11Z

@Jayxiang please see the issues and my comments regarding the SwiftLint warnings

SD10 · 2020-07-17T14:20:47Z

Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃

* 'master' of https://github.com/SwifterSwift/SwifterSwift: (79 commits) Helper functions for scrolling to the edges or by page of a scroll view (SwifterSwift#888) Add XCTest extension for comparing Color objects (SwifterSwift#889) Fix swiftlint error (SwifterSwift#894) Bump kramdown from 2.1.0 to 2.3.0 (SwifterSwift#891) Added note for UIView.addShadow() (SwifterSwift#890) loadFromNib(withClass) (SwifterSwift#885) constraint finders (widthConstraint, heightConstraint, leadingConstraint, trailingConstraint, topConstraint, bottomConstraint) (SwifterSwift#886) added String.regexEscaped (SwifterSwift#883) Make √ generic for FloatingPoint values (SwifterSwift#880) Update UITextField extensions (SwifterSwift#878) Added `masksToBounds` (IBInspectable) extension (SwifterSwift#877) Reinstate debounce function (SwifterSwift#869) `RandomAccessCollection`/`Collection` generalisations (SwifterSwift#863) Added HKActivitySummary extensions (SwifterSwift#875) Added new method for easily instantiating a view controller from a storyboard (SwifterSwift#860) Clean up code (SwifterSwift#864) fixed "".truncated crashed (SwifterSwift#866) Deprecated map(by:), compactMap(by:), filter(by:) (SwifterSwift#862) Overloaded 'contains' operator for string regex matching (SwifterSwift#858) Added convenient wrapper to asyncAfter (SwifterSwift#859) ... # Conflicts: # Sources/SwifterSwift/AppKit/NSColorExtensions.swift # Sources/SwifterSwift/AppKit/NSImageExtensions.swift # Sources/SwifterSwift/AppKit/NSViewExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGColorExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGFloatExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGPointExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGSizeExtensions.swift # Sources/SwifterSwift/Foundation/NSAttributedStringExtensions.swift # Sources/SwifterSwift/SwiftStdlib/StringExtensions.swift # SwifterSwift.xcodeproj/project.pbxproj # Tests/AppKitTests/NSColorExtensionsTests.swift # Tests/SwiftStdlibTests/StringExtensionsTests.swift

Update UITextField extensions

1ef6d0a

Update UITextField extensions,fixed UITextField addPaddingLeftIcon doesn't work on iOS 13,add addPaddingRight,addPaddingRightIcon

LucianoPAlmeida requested review from omaralbeik and guykogus July 15, 2020 17:16

rypyak reviewed Jul 16, 2020

View reviewed changes

Sources/SwifterSwift/UIKit/UITextFieldExtensions.swift Show resolved Hide resolved

guykogus requested changes Jul 17, 2020

View reviewed changes

Jayxiang and others added 2 commits July 17, 2020 18:24

Update Tests/UIKitTests/UITextFieldExtensionsTests.swift

d040745

Co-authored-by: Guy Kogus <guy.kogus@gmail.com>

Update Tests/UIKitTests/UITextFieldExtensionsTests.swift

395947b

Co-authored-by: Guy Kogus <guy.kogus@gmail.com>

guykogus requested changes Jul 17, 2020

View reviewed changes

Jayxiang added 3 commits July 17, 2020 18:49

Update UITextField extensions and tests

f42d6d0

Add changelog

d0cf3fb

Update UITextFieldExtensionsTests.swift

443cacd

Jayxiang and others added 2 commits July 17, 2020 21:35

Avoid SwiftLint errors

1e8db5c

Merge branch 'master' into master

33ba375

guykogus approved these changes Jul 17, 2020

View reviewed changes

LucianoPAlmeida merged commit 59522d7 into SwifterSwift:master Jul 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update UITextField extensions #878

Update UITextField extensions #878

Uh oh!

Jayxiang commented Jul 13, 2020 •

edited

Loading

Uh oh!

codecov bot commented Jul 13, 2020 •

edited

Loading

Uh oh!

Uh oh!

guykogus left a comment

Uh oh!

Uh oh!

guykogus Jul 17, 2020

Uh oh!

Uh oh!

Uh oh!

SwifterSwiftBot commented Jul 17, 2020 •

edited

Loading

Uh oh!

guykogus Jul 17, 2020

Uh oh!

guykogus Jul 17, 2020

Uh oh!

guykogus Jul 17, 2020

Uh oh!

guykogus Jul 17, 2020

Uh oh!

guykogus commented Jul 17, 2020

Uh oh!

SD10 commented Jul 17, 2020

Uh oh!

Uh oh!

		let paddingView = UIView(frame: CGRect(x: 0, y: 0, width: padding, height: frame.height))
		rightView = paddingView

	let paddingView = UIView(frame: CGRect(x: 0, y: 0, width: padding, height: frame.height))
	rightView = paddingView
	rightView = UIView(frame: CGRect(x: 0, y: 0, width: padding, height: bounds.height))

	let image = UIImage(named: "TestImage", in: bundle)!
	let image = UIImage(named: "TestImage", in: bundle, compatibleWith: nil)!

Update UITextField extensions #878

Update UITextField extensions #878

Uh oh!

Conversation

Jayxiang commented Jul 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

codecov bot commented Jul 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

guykogus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

guykogus Jul 17, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SwifterSwiftBot commented Jul 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guykogus Jul 17, 2020

Choose a reason for hiding this comment

Uh oh!

guykogus Jul 17, 2020

Choose a reason for hiding this comment

Uh oh!

guykogus Jul 17, 2020

Choose a reason for hiding this comment

Uh oh!

guykogus Jul 17, 2020

Choose a reason for hiding this comment

Uh oh!

guykogus commented Jul 17, 2020

Uh oh!

SD10 commented Jul 17, 2020

Uh oh!

Uh oh!

Jayxiang commented Jul 13, 2020 •

edited

Loading

codecov bot commented Jul 13, 2020 •

edited

Loading

SwifterSwiftBot commented Jul 17, 2020 •

edited

Loading