Skip to content

Conversation

hamtiko
Copy link
Member

@hamtiko hamtiko commented Jul 11, 2020

Sometimes we need to set masksToBounds property of UIView from storyboard.

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 5.0.
  • New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #877 into master will decrease coverage by 2.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
- Coverage   95.48%   92.82%   -2.66%     
==========================================
  Files         100      100              
  Lines        3411     3415       +4     
==========================================
- Hits         3257     3170      -87     
- Misses        154      245      +91     
Flag Coverage Δ
#ios 95.59% <100.00%> (+<0.01%) ⬆️
#macos 82.95% <ø> (-14.14%) ⬇️
#tvos 93.58% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
Sources/SwifterSwift/UIKit/UIViewExtensions.swift 81.57% <100.00%> (+0.32%) ⬆️
...ources/SwifterSwift/AppKit/NSColorExtensions.swift 0.00% <0.00%> (-100.00%) ⬇️
Sources/SwifterSwift/AppKit/NSViewExtensions.swift 0.00% <0.00%> (-96.83%) ⬇️
...ources/SwifterSwift/AppKit/NSImageExtensions.swift 0.00% <0.00%> (-70.38%) ⬇️
.../SwifterSwift/CoreGraphics/CGColorExtensions.swift 50.00% <0.00%> (-50.00%) ⬇️
...ces/SwifterSwift/Shared/EdgeInsetsExtensions.swift 86.48% <0.00%> (-13.52%) ⬇️
...es/SwifterSwift/SwiftStdlib/StringExtensions.swift 99.50% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f1917...c65e5e2. Read the comment docs.

@SwifterSwiftBot
Copy link

SwifterSwiftBot commented Jul 11, 2020

4 Messages
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.
📖 iOS: Executed 685 tests, with 0 failures (0 unexpected) in 24.823 (26.516) seconds
📖 tvOS: Executed 647 tests, with 0 failures (0 unexpected) in 6.802 (8.794) seconds
📖 macOS: Executed 512 tests, with 0 failures (0 unexpected) in 4.000 (4.196) seconds

Generated by 🚫 Danger

Copy link
Member

@LucianoPAlmeida LucianoPAlmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@omaralbeik omaralbeik self-requested a review July 12, 2020 07:38
omaralbeik
omaralbeik previously approved these changes Jul 12, 2020
Copy link
Member

@omaralbeik omaralbeik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@guykogus guykogus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just 1 tiny suggested change and then we can merge.

Co-authored-by: Guy Kogus <guy.kogus@gmail.com>
@hamtiko hamtiko dismissed stale reviews from omaralbeik and LucianoPAlmeida via c65e5e2 July 13, 2020 15:26
@guykogus guykogus merged commit 055732c into SwifterSwift:master Jul 13, 2020
nasircsms pushed a commit to nasircsms/SwifterSwift that referenced this pull request Aug 26, 2020
* 'master' of https://github.com/SwifterSwift/SwifterSwift: (79 commits)
  Helper functions for scrolling to the edges or by page of a scroll view (SwifterSwift#888)
  Add XCTest extension for comparing Color objects (SwifterSwift#889)
  Fix swiftlint error (SwifterSwift#894)
  Bump kramdown from 2.1.0 to 2.3.0 (SwifterSwift#891)
  Added note for UIView.addShadow() (SwifterSwift#890)
  loadFromNib(withClass) (SwifterSwift#885)
  constraint finders (widthConstraint, heightConstraint, leadingConstraint, trailingConstraint, topConstraint, bottomConstraint) (SwifterSwift#886)
  added String.regexEscaped (SwifterSwift#883)
  Make √ generic for FloatingPoint values (SwifterSwift#880)
  Update UITextField extensions (SwifterSwift#878)
  Added `masksToBounds` (IBInspectable) extension (SwifterSwift#877)
  Reinstate debounce function (SwifterSwift#869)
  `RandomAccessCollection`/`Collection` generalisations (SwifterSwift#863)
  Added HKActivitySummary extensions (SwifterSwift#875)
  Added new method for easily instantiating a view controller from a storyboard (SwifterSwift#860)
  Clean up code (SwifterSwift#864)
  fixed "".truncated crashed (SwifterSwift#866)
  Deprecated map(by:), compactMap(by:), filter(by:) (SwifterSwift#862)
  Overloaded 'contains' operator for string regex matching (SwifterSwift#858)
  Added convenient wrapper to asyncAfter (SwifterSwift#859)
  ...

# Conflicts:
#	Sources/SwifterSwift/AppKit/NSColorExtensions.swift
#	Sources/SwifterSwift/AppKit/NSImageExtensions.swift
#	Sources/SwifterSwift/AppKit/NSViewExtensions.swift
#	Sources/SwifterSwift/CoreGraphics/CGColorExtensions.swift
#	Sources/SwifterSwift/CoreGraphics/CGFloatExtensions.swift
#	Sources/SwifterSwift/CoreGraphics/CGPointExtensions.swift
#	Sources/SwifterSwift/CoreGraphics/CGSizeExtensions.swift
#	Sources/SwifterSwift/Foundation/NSAttributedStringExtensions.swift
#	Sources/SwifterSwift/SwiftStdlib/StringExtensions.swift
#	SwifterSwift.xcodeproj/project.pbxproj
#	Tests/AppKitTests/NSColorExtensionsTests.swift
#	Tests/SwiftStdlibTests/StringExtensionsTests.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants