Added HKActivitySummary extensions #875

lhygilbert · 2020-07-04T01:16:20Z

Checklist

I checked the Contributing Guidelines before creating this request.
New extensions are written in Swift 5.0.
New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
I have added tests for new extensions, and they passed.
All extensions have a clear comments explaining their functionality, all parameters and return type in English.
All extensions are declared as public.
I have added a changelog entry describing my changes.

codecov · 2020-07-04T01:21:39Z

Codecov Report

Merging #875 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #875   +/-   ##
=======================================
  Coverage   95.47%   95.48%           
=======================================
  Files         100      101    +1     
  Lines        3405     3408    +3     
=======================================
+ Hits         3251     3254    +3     
  Misses        154      154

Flag	Coverage Δ
#ios	`95.58% <100.00%> (+<0.01%)`	⬆️
#macos	`97.08% <ø> (-1.46%)`	⬇️
#tvos	`93.56% <ø> (ø)`

Impacted Files	Coverage Δ
...rSwift/HealthKit/HKActivitySummaryExtensions.swift	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75ea86...b1407db. Read the comment docs.

SwifterSwiftBot · 2020-07-04T01:38:46Z

	4 Messages
📖	Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.
📖	iOS: Executed 683 tests, with 0 failures (0 unexpected) in 32.570 (33.758) seconds
📖	tvOS: Executed 645 tests, with 0 failures (0 unexpected) in 4.113 (4.636) seconds
📖	macOS: Executed 511 tests, with 0 failures (0 unexpected) in 4.069 (4.288) seconds

Generated by 🚫 Danger

LucianoPAlmeida · 2020-07-04T01:58:20Z

Sources/SwifterSwift/HealthKit/HKActivitySummaryExtensions.swift

+        let unit = HKUnit.count()
+        let standHours = appleStandHours.doubleValue(for: unit)
+        let goal = appleStandHoursGoal.doubleValue(for: unit)
+        return standHours >= goal


I don't know this API ... but there is the possibility of not having a goal set? what happens in this situation in doubleValue return?

In real life, the goal is always set when fetching HKActivitySummary from HealthKit

Sources/SwifterSwift/HealthKit/HKActivitySummaryExtensions.swift

LucianoPAlmeida

@lhygilbert Thanks for the PR, overall looks good just some questions

LucianoPAlmeida

LGTM Then :)
cc @omaralbeik @guykogus

LucianoPAlmeida

Great! that looks better :)

guykogus

A few minor comments

guykogus · 2020-07-04T17:27:49Z

Sources/SwifterSwift/HealthKit/HKActivitySummaryExtensions.swift

+    var isStandGoalMet: Bool {
+        return appleStandHoursGoal.compare(appleStandHours) != .orderedDescending
+    }


You can make these all 1-liners.

Suggested change

var isStandGoalMet: Bool {

return appleStandHoursGoal.compare(appleStandHours) != .orderedDescending

}

var isStandGoalMet: Bool { appleStandHoursGoal.compare(appleStandHours) != .orderedDescending }

Thanks for the suggestion, updated

guykogus · 2020-07-04T17:28:08Z

Sources/SwifterSwift/HealthKit/HKActivitySummaryExtensions.swift

+    }
+
+    /// SwifterSwift: Check if exercise time goal is met
+    var isExerciseGoalMet: Bool {


I think the names should match more exactly.

Suggested change

var isExerciseGoalMet: Bool {

var isExerciseTimeGoalMet: Bool {

guykogus · 2020-07-04T17:28:21Z

Sources/SwifterSwift/HealthKit/HKActivitySummaryExtensions.swift

+    }
+
+    /// SwifterSwift: Check if active energy goal is met
+    var isEnergyGoalMet: Bool {


Same here

Suggested change

var isEnergyGoalMet: Bool {

var isEnergyBurnedGoalMet: Bool {

…K api name

CHANGELOG.md

Update to match new properties name Co-authored-by: Guy Kogus <guy.kogus@gmail.com>

SD10 · 2020-07-05T21:29:34Z

Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃

* 'master' of https://github.com/SwifterSwift/SwifterSwift: (79 commits) Helper functions for scrolling to the edges or by page of a scroll view (SwifterSwift#888) Add XCTest extension for comparing Color objects (SwifterSwift#889) Fix swiftlint error (SwifterSwift#894) Bump kramdown from 2.1.0 to 2.3.0 (SwifterSwift#891) Added note for UIView.addShadow() (SwifterSwift#890) loadFromNib(withClass) (SwifterSwift#885) constraint finders (widthConstraint, heightConstraint, leadingConstraint, trailingConstraint, topConstraint, bottomConstraint) (SwifterSwift#886) added String.regexEscaped (SwifterSwift#883) Make √ generic for FloatingPoint values (SwifterSwift#880) Update UITextField extensions (SwifterSwift#878) Added `masksToBounds` (IBInspectable) extension (SwifterSwift#877) Reinstate debounce function (SwifterSwift#869) `RandomAccessCollection`/`Collection` generalisations (SwifterSwift#863) Added HKActivitySummary extensions (SwifterSwift#875) Added new method for easily instantiating a view controller from a storyboard (SwifterSwift#860) Clean up code (SwifterSwift#864) fixed "".truncated crashed (SwifterSwift#866) Deprecated map(by:), compactMap(by:), filter(by:) (SwifterSwift#862) Overloaded 'contains' operator for string regex matching (SwifterSwift#858) Added convenient wrapper to asyncAfter (SwifterSwift#859) ... # Conflicts: # Sources/SwifterSwift/AppKit/NSColorExtensions.swift # Sources/SwifterSwift/AppKit/NSImageExtensions.swift # Sources/SwifterSwift/AppKit/NSViewExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGColorExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGFloatExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGPointExtensions.swift # Sources/SwifterSwift/CoreGraphics/CGSizeExtensions.swift # Sources/SwifterSwift/Foundation/NSAttributedStringExtensions.swift # Sources/SwifterSwift/SwiftStdlib/StringExtensions.swift # SwifterSwift.xcodeproj/project.pbxproj # Tests/AppKitTests/NSColorExtensionsTests.swift # Tests/SwiftStdlibTests/StringExtensionsTests.swift

lhygilbert added 2 commits July 3, 2020 17:54

Add HKActivitySummaryExtensions

11a30e3

Update changelog, readme, podspec

0b70b87

Add @available watch os 2.2 to extensions

b7ceef7

LucianoPAlmeida reviewed Jul 4, 2020

View reviewed changes

Sources/SwifterSwift/HealthKit/HKActivitySummaryExtensions.swift Outdated Show resolved Hide resolved

LucianoPAlmeida reviewed Jul 4, 2020

View reviewed changes

LucianoPAlmeida previously approved these changes Jul 4, 2020

View reviewed changes

LucianoPAlmeida requested review from guykogus and omaralbeik July 4, 2020 03:02

Use .compare to avoid using an arbitrary unit

e19fe86

lhygilbert dismissed LucianoPAlmeida’s stale review via e19fe86 July 4, 2020 03:10

lhygilbert requested a review from LucianoPAlmeida July 4, 2020 03:18

LucianoPAlmeida previously approved these changes Jul 4, 2020

View reviewed changes

guykogus requested changes Jul 4, 2020

View reviewed changes

Update properties to be 1-liner. Update property name to match with H…

8b7d269

…K api name

lhygilbert dismissed LucianoPAlmeida’s stale review via 8b7d269 July 4, 2020 18:02

LucianoPAlmeida previously approved these changes Jul 5, 2020

View reviewed changes

LucianoPAlmeida requested a review from guykogus July 5, 2020 15:28

guykogus requested changes Jul 5, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

b1407db

Update to match new properties name Co-authored-by: Guy Kogus <guy.kogus@gmail.com>

lhygilbert dismissed LucianoPAlmeida’s stale review via b1407db July 5, 2020 20:33

LucianoPAlmeida approved these changes Jul 5, 2020

View reviewed changes

guykogus approved these changes Jul 5, 2020

View reviewed changes

guykogus merged commit 3739cd9 into SwifterSwift:master Jul 5, 2020

	var isExerciseGoalMet: Bool {
	var isExerciseTimeGoalMet: Bool {

	var isEnergyGoalMet: Bool {
	var isEnergyBurnedGoalMet: Bool {

Added HKActivitySummary extensions #875

Added HKActivitySummary extensions #875

Uh oh!

Conversation

lhygilbert commented Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

codecov bot commented Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SwifterSwiftBot commented Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LucianoPAlmeida Jul 4, 2020

Choose a reason for hiding this comment

Uh oh!

lhygilbert Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LucianoPAlmeida left a comment

Choose a reason for hiding this comment

Uh oh!

LucianoPAlmeida left a comment

Choose a reason for hiding this comment

Uh oh!

LucianoPAlmeida left a comment

Choose a reason for hiding this comment

Uh oh!

guykogus left a comment

Choose a reason for hiding this comment

Uh oh!

guykogus Jul 4, 2020

Choose a reason for hiding this comment

Uh oh!

lhygilbert Jul 4, 2020

Choose a reason for hiding this comment

Uh oh!

guykogus Jul 4, 2020

Choose a reason for hiding this comment

Uh oh!

lhygilbert Jul 4, 2020

Choose a reason for hiding this comment

Uh oh!

guykogus Jul 4, 2020

Choose a reason for hiding this comment

Uh oh!

lhygilbert Jul 4, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SD10 commented Jul 5, 2020

Uh oh!

Uh oh!

lhygilbert commented Jul 4, 2020 •

edited

Loading

codecov bot commented Jul 4, 2020 •

edited

Loading

SwifterSwiftBot commented Jul 4, 2020 •

edited

Loading

lhygilbert Jul 4, 2020 •

edited

Loading