Switch to the standard library Result type #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation never handled failure properly and would crash when attempting to force-unwrap a nonexistent success value.
mdiep
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5 added a
Resultenum to the standard library that can be used in place of antitypical/Result.The only change to the Result type's API, as used but SwiftGit2, is that the new type doesn't have the optional-returning
valueanderroraccessors. In the tests, I've added shims to re-implement those properties until Nimble adds matchers for the new Result. In the library itself, I've refactored the code that used those properties to use switch statements instead. This new approach produces code with fewer force-unwraps, and also revealed places where failure handling was previously implemented incorrectly.