fix: sync resume folder #1208
Merged
fix: sync resume folder #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved and modified the test case for resuming a non-existent experiment to use the 'reinit=True' parameter and ensure a RuntimeError is raised as expected.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a column type error that occurs when syncing a resume folder. The issue was that hardware monitoring column information was saved in backup files even when hardware monitoring was disabled during resume, causing display problems when syncing the resumed folder.
- Adds logic to properly map
column_classtosection_typebased on system vs custom classification - Updates test file to improve test organization by moving exception test to the end
- Introduces comprehensive test coverage for column class and type mappings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| swanlab/data/run/key.py | Implements proper section_type mapping based on column_class and chart type |
| test/unit/data/run/test_key.py | Adds parametrized tests for column_class and column_type section_type mapping |
| test/resume/must.py | Reorganizes test structure by moving exception test after successful operations |
Comments suppressed due to low confidence (1)
test/unit/data/run/test_key.py:53
- The test only covers ECHARTS mapping to CUSTOM section_type, but the production code logic suggests other chart types should map to PUBLIC. Consider adding test cases for other chart types to ensure complete coverage of the section_type mapping logic.
["ECHARTS", "CUSTOM"],
Replaced value-based comparison with identity comparison for ChartType.ECHARTS to ensure correct section type assignment.
Zeyi-Lin
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 sync 一个 resume 的 folder 会出现的列类型错误
现在的设计是 resume 时硬件监控不会开启，但是考虑到后续的更新，在backup file文件夹依旧保存了硬件监控相关的列信息
当 sync resume 的文件夹时就出现了列的类型错误，导致显示问题