Handle backup write errors and improve timer cancel #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added error handling for backup file write failures in porter/__init__.py to prevent crashes when backup mode is not enabled. Updated MonitorCron.cancel in run/helper.py to join the timer thread after cancellation for better thread management.
Corrected the logic for enabling system monitoring in SwanLabRun by changing the condition from 'or' to 'and'. Increased the number of epochs in the test_sync unit test to 10000 for more extensive testing.
Zeyi-Lin
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复在进程退出时可能因为硬件监控存在于单独线程导致的文件句柄状态冲突问题，两头堵：